Closed Bug 1662483 Opened 1 year ago Closed 1 year ago

Crash in [@ nsTextControlFrame::UpdatePlaceholderText]

Categories

(Core :: DOM: Editor, defect)

defect

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox80 --- unaffected
firefox81 --- unaffected
firefox82 --- fixed

People

(Reporter: aryx, Assigned: emilio)

References

(Regression)

Details

(Keywords: crash, regression, testcase)

Crash Data

Attachments

(2 obsolete files)

Frequent crash from the changes in bug 1658302.

Crash report: https://crash-stats.mozilla.org/report/index/d35d7e9c-2912-4aeb-8feb-5845b0200901

Top 9 frames of crashing thread:

0 xul.dll nsTextControlFrame::UpdatePlaceholderText layout/forms/nsTextControlFrame.cpp:510
1 xul.dll nsTextControlFrame::PlaceholderChanged layout/forms/nsTextControlFrame.cpp:496
2 xul.dll mozilla::dom::HTMLInputElement::AfterSetAttr dom/html/HTMLInputElement.cpp:1289
3 xul.dll mozilla::dom::Element::SetAttrAndNotify dom/base/Element.cpp:2359
4 xul.dll mozilla::dom::Element::SetAttr dom/base/Element.cpp:2216
5 xul.dll mozilla::dom::Element::SetAttribute dom/base/Element.cpp:1294
6 xul.dll mozilla::dom::Element_Binding::setAttribute dom/bindings/ElementBinding.cpp:1345
7 xul.dll mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions> dom/bindings/BindingUtils.cpp:3227
8  @0xbf8e2be9 
Flags: needinfo?(emilio)
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Flags: needinfo?(emilio)
Attached file testcase.html (obsolete) —

Fuzzers are hitting this too.

Flags: in-testsuite?
Keywords: testcase
Comment on attachment 9173470 [details]
testcase.html

><script>
>window.onload = () => {
>  a.placeholder = "x"
>  a.placeholder = ""
>}
></script>
><textarea id="a">a</textarea>
Attachment #9173470 - Attachment is obsolete: true

Sorry about that, I should have looked at the patch first. Also fuzzing builds we not being updated that's why there was such a delay.

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

For the record, the patch here shall still land once reviewed (together with the re-land of bug 1658302).

Attachment #9173382 - Attachment is obsolete: true
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.