1662489 - Replace chat icons with SVGs

Status: RESOLVED FIXED

(Chat Core :: General, enhancement)

Description

[Patrick Cloke [:clokep]]

Attachment: chat-svgs.zip

I came across a zip file from Florian that included the sources for all of the Instantbird icons, so it includes the SVG versions of many of the icons used for chat / instant messaging code in Thunderbird.

I've tried to organize them a bit, the status icons in particular are a bit confusing (I think the ones including Thunderbird have been combined into a single image and exist both under chat/ and mail/components/im?). Unfortunately there aren't SVGs for all the protocols (and the Twitter icon looks older).

These are not from me, but as they were created for Instantbird I believe they're licensed under MPL.

I have a bunch of other icons too, but I think they're all Instantbird specific.

Comment 1

[Florian Quèze [:florian]]

(In reply to Patrick Cloke [:clokep] from comment #0)

Created attachment 9173387 [details]
chat-svgs.zip

These are not from me, but as they were created for Instantbird I believe they're licensed under MPL.

The icons in the 'protocols' folder of your zip file look like icons we took from Pidgin, so likely GPL. Everything else in your zip file was created for Instantbird, and is MPL.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1662489-chat-icons-SVG.patch

I exchanged all icons I could. I leaved the protocol icons because I need SVGs for every protocol. We can't mix on the protocols the icon types because they are set through JS.

If we have them for all protocols we can do this in a follow-up bug.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9174098 [details] [diff] [review]
1662489-chat-icons-SVG.patch

Review of attachment 9174098 [details] [diff] [review]:
-----------------------------------------------------------------

These are a good improvements but there are some things that we should change.

- Let's name the icons for they're used, so let's do something like `status-offline`, `status-away`, etc., instead of using the colors for names.
- The unknown-protocol and the 16 variation should use the question mark we're using in the message-signed-unknown.svg icon
- The status icons have a strange flat gradient to represent a sphere, and the colors are a bit too saturated and neon. I'm gonna updated those in Inkscape and upload a zip with an updated version.

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: chat-status.zip

Status icons updated. They're not optimized

Comment 5

[Patrick Cloke [:clokep]]

If we have them for all protocols we can do this in a follow-up bug.

I think doing the protocols as a follow-up makes sense, especially since it sounds like we'll need icons from scratch anyway (see comment 1).

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1662489-chat-icons-SVG.patch

Updated the icons.

Comment 7

[Alessandro Castellani [:aleca]]

Comment on attachment 9174405 [details] [diff] [review]
1662489-chat-icons-SVG.patch

Review of attachment 9174405 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cc16d83efd05
Replace chat icons with SVGs. r=aleca

Comment 9

[Geoff Lankow (:darktrojan)]

FYI you missed one sheet that referenced secure.png and insecure.png. I fixed it for you. mach mochitest browser_parsable_css.js is your friend.