1662502 - Barrier implementations are repeated in several places

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P1)

Description

[Jon Coppeard (:jonco)]

We can refactor the barrier implementations to give Cell default implementations for pre and read barriers, and combine the existing post barrier implementations into a single function.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1662502 - Refactor barrier implemenations r?sfink

This moves the default barrier implementations for the pre and read barriers to
the Cell base class and combines the existing post barrier implemenations in to
a single function.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1662502 - Rename some methods on GC wrapped pointers to 'unbarriered' rather than 'unsafe' r?sfink

This should clarify why they are unsafe.

Also rename the overlong 'unsafeUnbarrieredForTracing' to 'unbarrieredAddress'
to be more like Rooted::address and since it is used outside of tracing in a
couple of places.

Depends on D89011

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c7a708e37e2
Refactor barrier implemenations r=sfink
https://hg.mozilla.org/integration/autoland/rev/0f13b3d0e5dd
Rename some methods on GC wrapped pointers to 'unbarriered' rather than 'unsafe' r=sfink

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/5c7a708e37e2
https://hg.mozilla.org/mozilla-central/rev/0f13b3d0e5dd