1662509 - Add a pref to experiment with zero-prefix search in search mode

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P1)

Description

[Harry Twyford]

UX wants to experiment with how we handle zero-prefix searches in search mode. We should add a multi-value toggle that allows us to experiment with:

• Showing nothing
• Showing a mix of search history and Places history (what we do currently)
• Just showing search history

This pref should also support future experimental behaviours, like trending searches.

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1662509 - Add a pref to experiment with zero-prefix search in search mode. r=harry

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a526a04f7f4c
Add a pref to experiment with zero-prefix search in search mode. r=harry

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset a526a04f7f4c (bug 1662509) for Reftest failures in js/src/tests/test262/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-4.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315602564&repo=autoland&lineNumber=2066

Push with failure:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=a526a04f7f4c30275176a567d5d94f4606c282f7

Backout:
https://hg.mozilla.org/integration/autoland/rev/7e632b8c7491f082fd09233c8236e16370f63108

Comment 4

[Marco Bonardo [:mak]]

uh, I wonder how my change can affect a js regexp test?

Comment 5

[Marco Bonardo [:mak]]

I wonder if it's because I wrongly put a comma in firefox.js

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7bf67ecaeb9
Add a pref to experiment with zero-prefix search in search mode. r=harry

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/c7bf67ecaeb9