1662518 - Use dummy result for nsIPrinter::SupportsColor with older CUPS

Status: RESOLVED FIXED

(Core :: Printing: Setup, enhancement, P1)

Description

[Emily McDonough [:alaskanemily]]

Based on the investigation in 1660658, it appears that older CUPS returns incorrect values for color support. We should add a version check for the printer's server, and if it is before a threshold just return true to allow color printing.

Comment 1

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1662518 part 1 - Add semver to gkrust_util

We will use this for CUPS version parsing.

Comment 2

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1662518 part 2 - Get CUPS server version info for each printer.

Comment 3

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1662518 part 3 - Use a dummy value for nsPrinterCUPS::SupportsColor if CUPS is older than 2.2

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7b557363e1b
part 1 - Add semver to gkrust_util r=emilio
https://hg.mozilla.org/integration/autoland/rev/43f006fdc369
part 2 - Get CUPS server version info for each printer. r=emilio,jwatt
https://hg.mozilla.org/integration/autoland/rev/75e7a560323a
part 3 - Use a dummy value for nsPrinterCUPS::SupportsColor if CUPS is older than 2.2 r=emilio,jwatt

Comment 5

[Emily McDonough [:alaskanemily]]

Comment on attachment 9173458 [details]
Bug 1662518 part 3 - Use a dummy value for nsPrinterCUPS::SupportsColor if CUPS is older than 2.2

Beta/Release Uplift Approval Request

• User impact if declined: Users with older versions of CUPS (in particular Ubuntu 16) will likely be unable to choose color printing in the new print UI for some printers.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): We haven't really had the time to properly test if this actually fixes bug 1660658, but it shouldn't cause serious problems if it turns out to be unnecessary. At worst, some black-and-white only printers on very old CUPS (such as on Ubuntu 16, but not Ubuntu 18+) would appear to be color during print preview. It will only affect the new printing UI in any case.
• String changes made/needed:

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f7b557363e1b
https://hg.mozilla.org/mozilla-central/rev/43f006fdc369
https://hg.mozilla.org/mozilla-central/rev/75e7a560323a

Comment 7

[Lee McFarland]

This cannot be verified as resolved until bug 1662946 is corrected as the hang condition renders it impossible to use the print function at all.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9173456 [details]
Bug 1662518 part 1 - Add semver to gkrust_util

Approved for 81.0b6.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/599da6c68d76
https://hg.mozilla.org/releases/mozilla-beta/rev/6175fefe8461
https://hg.mozilla.org/releases/mozilla-beta/rev/7da0b388dae0