1662526 - ServiceWorkerOp subclasses' Exec methods should return true if dispatch did not fail

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, task)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

By looking to ServiceWorkerOp::ServiceWorkerOpRunnable::WorkerRun it seems that we consider the ServiceWorkerOp as failed if its Exec method does return false, but in some of the ServiceWorkerOp subclasses the Exec method is returning DispatchFailed(...) and so they are going to return true when dispatching the operation did actually fail.

This issue is marked as a task because what described above shouldn't be currently triggering or hiding any actual issue (because in ServiceWorkerOp::ServiceWorkerOpRunnable::WorkerRun we are currently using that return value only to print a warning in debug builds).

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1662526 - Exec method of the ServiceWorkerOp subclasses should return true when a dispatch did not fail. r?asuth!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68a2b142761a
Exec method of the ServiceWorkerOp subclasses should return true when a dispatch did not fail. r=asuth

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/68a2b142761a