1662576 - Add list of domains for WebCompat add-on for which the Picture-in-Picture keyboard shortcuts should be disabled

Status: RESOLVED FIXED

(Web Compatibility :: Interventions, enhancement, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

Similar to how we override the default placement of the PiP toggle for certain sites, we'd like to make it so that the webcompat add-on can provide a list of domain matcher strings so that the player window knows which sites break when attempting to do things like seek, play or pause.

Perhaps something like:

const KEYBOARD_CONTROLS = browser.pictureInPictureChild.getKeyboardControls();

PIP_KEYBOARD_OVERRIDES: {
  "https://*.netflix.com/*": KEYBOARD_CONTROLS.PLAY_PAUSE | KEYBOARD_CONTROLS.VOLUME,
  "http://*.someothersite.com/*": KEYBOARD_CONTROLS.NONE,
},

Where KEYBOARD_CONTROLS could be a structure of bit constants like:

KEYBOARD_CONTROLS = {
  NONE: 0,
  PLAY_PAUSE: 1 << 0,
  MUTE_UNMUTE: 1 << 1,
  VOLUME: 1 << 2,
  SEEK: 1 << 3,
};

alternatively, if we don't want to do bitwise stuff, we could also do something like:

PIP_KEYBOARD_OVERRIDES: {
  "https://*.netflix.com/*": {
    playpause: true,
    volume: true,
  },
  "http://*.someothersite.com/*": {},
},

Comment 1

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1662576 - add ability to disable picture-in-picture hotkeys on specific domains in webcompat addon, and disable PiP-seeking on Netflix; r?mconley!,denschub!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3299eee79671
add ability to disable picture-in-picture hotkeys on specific domains in webcompat addon, and disable PiP-seeking on Netflix; r=mconley,denschub,webcompat-reviewers

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/3299eee79671