1662587 - pointerlock is broken if page contains an OOP iframe

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: test.html

STR:
Click on the canvas area in top-level document to request a pointer lock.

Expected results:
Mouse will directly control the red ball inside the canvas.

Actual result:
The mouse cursor is showed and locked inside the iframe.
And you can request a pointer lock again in iframe.

Comment 1

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

(In reply to Edgar Chen [:edgar] from comment #0)

The mouse cursor is showed and locked inside the iframe.

I think it is because we reset mouse/pointer to the window center while pointer lock is enabled, so it looks like we need to have some information stored in chrome process in order to dispatch event to the right content process.

Comment 2

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Bug 1662587 - Make pointer lock fission compatible;

Comment 3

[Neha Kochar [:neha]]

Edgar, please provide an estimate date for the patch in the Whiteboard field as M6b is nearing completion.

Comment 4

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Patch should be ready for review soon, probably later today.

Comment 5

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6bed2deee9adb20eab85c364b87aa02132335206

Comment 6

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: test.html

Comment 7

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=af659185871e76697a4f7f0bbd3fe4cff659927b

Comment 8

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9639f54caf1dfe7625a242a9d60a8eabda844ecc

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12856303559f
Make pointer lock fission compatible; r=smaug

Comment 10

[Narcis Beleuzu [:NarcisB]]

Backed out for mochitest crashes on test_pointerlock_xorigin_iframe.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/beef7a777c85e557c6f01f0ff01bf4fbcd80b830
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316224259&repo=autoland&lineNumber=3596

Comment 11

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Hmm, it seems asynchronously dispatch synthesized mouse event somehow doesn't work on Android, but I could not reproduce locally, seem to happen only on try? Filed bug 1666201.

Comment 12

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&tier=1&revision=39652daf17941094af803148474cecc9d7eb85f6

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45eb5295b99b
Make pointer lock fission compatible; r=smaug

Comment 14

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/45eb5295b99b