1662671 - 0.29 - 1.73% Base Content JS (linux1804-64-shippable, linux1804-64-shippable-qr, macosx1014-64-shippable, windows10-64-shippable-qr, windows7-32-shippable) regression on push e763b6e09a4914247ab86b3600acac8562e6c1d1 (Fri August 28 2020)

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[Florin Strugariu [:Bebe]]

Perfherder has detected a awsy performance regression from push e763b6e09a4914247ab86b3600acac8562e6c1d1. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

2% Base Content JS windows10-64-shippable-qr opt 3,453,306.67 -> 3,512,886.67
2% Base Content JS windows10-64-shippable-qr opt 3,458,057.33 -> 3,512,593.33
2% Base Content JS windows7-32-shippable opt 2,665,794.67 -> 2,706,365.33
0.32% Base Content JS macosx1014-64-shippable opt 3,453,042.67 -> 3,464,122.00
0.29% Base Content JS linux1804-64-shippable opt 3,448,573.33 -> 3,458,523.33
0.29% Base Content JS linux1804-64-shippable-qr opt 3,448,573.33 -> 3,458,540.00

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1589102

Comment 2

[Anny Gakhokidze [:annyG]]

My team who is responsible for setting the memory usage level for acceptable base content JS said that this memory regression is not huge enough to back out my patches, but investigating what caused this is my first priority and I have been looking into this since it was first reported.

Comment 3

[Florin Strugariu [:Bebe]]

We also have a raptor regression:

== Change summary for alert #26870 (as of Fri, 04 Sep 2020 15:38:30 GMT) ==

Regressions:

21% raptor-tp6-outlook-firefox-cold macosx1014-64-shippable opt 448.64 -> 544.77
11% raptor-tp6-outlook-firefox-cold fcp macosx1014-64-shippable opt 332.08 -> 369.83

Improvements:

52% raptor-tp6-sheets-firefox-cold loadtime windows10-64-shippable opt 4,551.15 -> 2,186.75
15% raptor-tp6-sheets-firefox-cold windows10-64-shippable opt 1,043.20 -> 886.74

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26870

Comment 4

[Anny Gakhokidze [:annyG]]

:Bebe I submitted a try job with my patches reverted and run a raptors test to compare performance. You can see in the results here that the confidence is very low. It seems that the results in the original alert are noisy and my patch did not cause the 20% and 11% regression.

Comment 5

[Florin Strugariu [:Bebe]]

My mistake with the 2 regressions I reassigned them to the correct regerssion

Comment 6

[Anny Gakhokidze [:annyG]]

Attachment: Bug 1662671 - Remove css for adding an unused resize property for Windows, r=neildeakin!

Before Quantum, we needed resizer icon on Windows, because when the
add-on statusbar was hidden, we could not resize the window. This is not
needed anymore and is dead code. Consequentially, this also helps reduce
unused images loaded at startup time.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

We have various special cases to support resizers on the root in layout which I think could go too...

Comment 8

[Anny Gakhokidze [:annyG]]

I was planning to create a follow up, didn't get around to it till now. It is now filed - bug 1667089. Hopefully under the right component...

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d7e7333f2fa
Remove css for adding an unused resize property for Windows, r=NeilDeakin,remote-protocol-reviewers,maja_zf

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/7d7e7333f2fa

Comment 11

[Florin Strugariu [:Bebe]]

== Change summary for alert #27070 (as of Mon, 28 Sep 2020 04:45:20 GMT) ==

Improvements:

5% Images windows10-64-shippable-qr opt 8,300,623.96 -> 7,875,611.41
5% Images windows10-64-shippable-qr opt tp6 10,317,247.58 -> 9,801,779.86
5% Base Content Explicit windows10-64-shippable opt 9,558,272.00 -> 9,095,168.00
3% Base Content Resident Unique Memory windows10-64-shippable opt 11,333,290.67 -> 10,941,952.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=27070