1662688 - Warp: support specialized calls and inlining of lambda clones

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P2)

Description

[Jan de Mooij [:jandem]]

The GuardSpecificFunction instruction doesn't work well when there are function clones. I have a patch that adds GuardFunctionScript to guard on the script instead of the function.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1662688 part 1 - Ensure native functions never have a valid BaseScript* in the 'extra' field. r?iain!

We want GuardFunctionScript to compare the JSFunction field without any flag checks
but that only works if native functions are guaranteed to not have an identical value
stored there.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1662688 part 2 - Add support for BaseScript stub fields. r?iain!

Depends on D89136

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1662688 part 3 - Add GuardFunctionScript CacheIR and MIR instructions. r?iain!

Depends on D89137

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1662688 part 4 - Support GuardFunctionScript in call specialization and trial inlining code. r?iain!

Depends on D89138

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1662688 part 5 - Emit GuardFunctionScript for scripted functions. r?iain!

Because guarding on the Class and the BaseScript is quite a bit slower than
GuardSpecificFunction, try the function guard if we're attaching the first stub.

Make trial inlining ignore the unused stub so we can still inline. This is similar
to the heuristics WarpOracle uses but is still a bit more conservative.

Depends on D89139

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Bug 1662688 part 6 - Use the canonical function for CompileInfo. r?iain!

This matches what we do for the main script in IonCompile and could prevent problems
with nursery-allocated functions.

Depends on D89140

Comment 7

[Jan de Mooij [:jandem]]

Attachment: Bug 1662688 part 6 - Check for previously-inlined ICScripts. r?iain!

This fixes an issue where we could inline twice at the same pc, confusing the
bailout code.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0870e9a8b74
part 1 - Ensure native functions never have a valid BaseScript* in the 'extra' field. r=iain
https://hg.mozilla.org/integration/autoland/rev/166f59b3f3b0
part 2 - Add support for BaseScript stub fields. r=iain
https://hg.mozilla.org/integration/autoland/rev/060f7da5ba7e
part 3 - Add GuardFunctionScript CacheIR and MIR instructions. r=iain
https://hg.mozilla.org/integration/autoland/rev/02d37579be32
part 4 - Support GuardFunctionScript in call specialization and trial inlining code. r=iain
https://hg.mozilla.org/integration/autoland/rev/a6f52a53ea98
part 5 - Emit GuardFunctionScript for scripted functions. r=iain
https://hg.mozilla.org/integration/autoland/rev/2d9a913e6f1f
part 6 - Check for previously-inlined ICScripts. r=iain

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d0870e9a8b74
https://hg.mozilla.org/mozilla-central/rev/166f59b3f3b0
https://hg.mozilla.org/mozilla-central/rev/060f7da5ba7e
https://hg.mozilla.org/mozilla-central/rev/02d37579be32
https://hg.mozilla.org/mozilla-central/rev/a6f52a53ea98
https://hg.mozilla.org/mozilla-central/rev/2d9a913e6f1f