1662691 - Range error (for invalid custom range) is displayed for “All” range as well

Status: VERIFIED FIXED

(Toolkit :: Printing, defect, P2)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: AllError.gif

Affected versions

• 82.0a1 (BuildId:20200901214943)
• 81.0b5 (BuildId:20200901203141)

Affected platforms

• Windows 10 64bit
• Ubuntu 18.04 64bit
• macOS 10.14

Steps to reproduce

1. Launch Firefox.
2. Access the following link.
3. Select an invalid Custom page range.
4. Switch to “all” page range fast.

Expected result

• The invalid page range error is not displayed for the “all” range even if the user has fastly changed from an invalid custom range to the “all” range.

Actual result

• The invalid page range error remains displayed even if the “all” range is selected.

Regression Window

• This seems to be a regression but I can't find the exact regressor using mozregression because it throws me some errors and quits the regression search. This is the furthest I can go -> https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=432e42cbbc4139efd2319952ec33efe8ff9add3c&tochange=369f72130f3604c85f73a3b03b2b48f33ad9b19e

Additional Information

• For further information regarding this issue please observe the attached screencast.
• [Suggested Severity] S3 or S4

Comment 1

[Blake Winton (:bwinton) (:☕️)]

(Emma probably knows what the fix here is…)

Comment 2

[Blake Winton (:bwinton) (:☕️)]

(Also, I can't reproduce this on macOS on the Nightly I just installed (82.0a1 (2020-09-02)), and I know we're doing some work in this area, so it might have been fixed by something that just landed. Specifically bug 1662145 looks similar.)

Comment 3

[Emil Ghitta, QA [:emilghitta]]

Odd...I can reproduce this issue using Firefox 82.0a1 (BuildId:20200902095359) on macOS 10.14..the trick is to change from custom to all pretty fast.

Comment 4

[Emma Malysz]

Attachment: Bug 1662691, ensure we clear the error timeout when switching to 'all' page range

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/682c2791c258
ensure we clear the error timeout when switching to 'all' page range r=sfoster

Comment 6

[Emma Malysz]

Comment on attachment 9173664 [details]
Bug 1662691, ensure we clear the error timeout when switching to 'all' page range

Beta/Release Uplift Approval Request

• User impact if declined: The user may incorrectly see an error message
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open firefox with printing.tab_modal.enabled turned on

2. Command P
3. Change the page range from custom to all
4. enter an invalid number in the range
5. In less than half a second (before the error shows), go from "custom" to "all"
6. Notice the error does not appear

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No strings
• String changes made/needed: n/a

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/682c2791c258

Comment 8

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 82.0a1 (BuildId:20200903094553) on Windows 10 64bit, macOS 10.14 & Ubuntu 18.04 64bit.

Leaving a ni? on myself and the qe-verify+ until this gets verified in beta as well.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9173664 [details]
Bug 1662691, ensure we clear the error timeout when switching to 'all' page range

Approved for 81.0b6.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d09b2b8e2164

Comment 11

[Emil Ghitta, QA [:emilghitta]]

This is verified fixed using Firefox 81.0b7 (BuildId:20200906164749) on Windows 10 64bit, macOS 10.14 & Ubuntu 18.04 64bit.

Comment 12

[Maria Berlinger [:mberlinger], Services QA]

https://testrail.stage.mozaws.net/index.php?/cases/view/1084525