1662710 - HTTPS-Only: Add UI to manage exceptions from about:preferences

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P3)

Description

[Julian Gaibler]

Attachment: mockup.jpg

Most permissions and even ETP have some sort of UI to manage exceptions in about:preferences#privacy.

HTTPS-Only mode users will probably need something similar to manage their current exceptions. Also, some websites behave in unpredictable ways when upgraded to HTTPS, which may prevent users from accessing per-site or error-page UI to add an exception. In these cases, the user could always use the UI in about:preferences to exempt sites from there.

Comment 3

[Julian Gaibler]

Attachment: Bug 1662710 - Added UI to manage HTTPS-Only Mode exceptions from about:preferences.

Comment 4

[Meridel [:meridel]]

Next week is Proton hand-off so ideally I would look at this the week of March 8. Is that too late? Please let me know if I am a blocker.

Comment 5

[Meridel [:meridel]]

Can you please share the Figma file with me?

And, why do we not offer "Exceptions" when enabled for Private Windows only?

Comment 6

[Julian Gaibler]

Figma: https://www.figma.com/file/WJb99TrcbCStWpO2Etyl4H/HTTPS-Only-Mode?node-id=3%3A812

And, why do we not offer "Exceptions" when enabled for Private Windows only?

Permissions set in private browsing and 'normal' browsing are not shared. So exceptions set in this UI do not apply to private windows, and exceptions set in private windows don't show up in this UI. (Also everything gets deleted once you close a private window, so there's no need to manage stuff ^^)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ccdbd76fc479
Added UI to manage HTTPS-Only Mode exceptions from about:preferences. r=flod,Gijs

Comment 8

[Julian Gaibler]

Since copy and design are done, I think I can clear Arthurs needinfo request :)

Comment 9

[Dorel Luca [:dluca]]

Backed out changeset ccdbd76fc479 (bug 1662710) for Browser-chrome failures in toolkit/components/passwordmgr/test/browser/browser_exceptions_dialog.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=340970970&repo=autoland&lineNumber=32369

https://treeherder.mozilla.org/logviewer?job_id=340970634&repo=autoland&lineNumber=2637

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=ccdbd76fc4799b318a00241e05f41c6e691c7110

Backout:
https://hg.mozilla.org/integration/autoland/rev/4f4f341eff6a89e87e9f22b2dc50458d5e868499

Comment 10

[Julian Gaibler]

Ah forgot to update tests -__-

Sorry

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8347db9863fc
Added UI to manage HTTPS-Only Mode exceptions from about:preferences. r=flod,Gijs

Comment 12

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/8347db9863fc

Comment 13

[Julien Cristau [:jcristau]]

Is this worth calling out in firefox 90 release notes? (If yes, see https://wiki.mozilla.org/Release_Management/Release_Notes#Nomination_in_Bugzilla)

Comment 14

[Julian Gaibler]

Release Note Request

Why is this notable: Exceptions were possible before, but could only be managed on a per-site basis, which many users didn't know.
Affects Firefox for Android: No
Links: Support Page (is not updated yet, but hopefully will be when 90 releases)