1662736 - Simplify the Network Request Payload sent from the server to the client.

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P2)

Description

[Hubert Boma Manilla (:bomsy) PTO until Jan 6th]

As a follow-up to Bug 1644191 We should cleanup and simplify the payload sent from the backend. Ideally match the structure that the redux store needs.

This should mean, we can remove most of the data mappings like this https://searchfox.org/mozilla-central/rev/84922363f4014eae684aabc4f1d06380066494c5/devtools/client/netmonitor/src/connector/firefox-data-provider.js#392-439

Comment 1

[Hubert Boma Manilla (:bomsy) PTO until Jan 6th]

Attachment: Bug 1662736 - Simplify the network request payload r=ochameau

Depends on D85822

Comment 2

[Hubert Boma Manilla (:bomsy) PTO until Jan 6th]

Attachment: Bug 1662736 - [devtools] Simplify the network request payload r=ochameau

Comment 3

[Hubert Boma Manilla (:bomsy) PTO until Jan 6th]

Attachment: Bug 1662736 - [devtools] Simplify the network resource payload for the server watcher r=ochameau

Depends on D94457

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1780d41127e8
[devtools] Simplify the network request payload r=ochameau

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing devtools failure.

Backout link: https://hg.mozilla.org/integration/autoland/rev/78ab270ce9fad27444166449c5789aedc43c66f5

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=Z6TLVnSVRt-SlvnBBznmlA.0&resultStatus=pending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2C18.04%2Cx64%2Copt%2Cnode%2Ctests%2Csource-test-node-devtools-tests%2Cdevtools&revision=1780d41127e87e81895652b529bdd9431280f954

Failure log: https://treeherder.mozilla.org/logviewer?job_id=321305099&repo=autoland&lineNumber=1712

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62af829812bd
[devtools] Simplify the network request payload r=ochameau

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/62af829812bd

Comment 8

[Andreea Pavel [:apavel]]

Backed out for permafailing bug 1676641 and bug 1655183

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=MahGTUNlS4ib06-BomYSsA.0&resultStatus=testfailed%2Cbusted%2Cexception&searchStr=windows%2C10%2Cx64%2Casan%2Cmochitests%2Ctest-windows10-64-asan%2Fopt-mochitest-devtools-chrome-e10s%2Cdt3&revision=8f7639a49ff44fec840321d427f0674c4bd2566e

Failure log: https://treeherder.mozilla.org/logviewer?job_id=321471139&repo=autoland&lineNumber=4215
and
https://treeherder.mozilla.org/logviewer?job_id=321477241&repo=autoland&lineNumber=2336

Backout: https://hg.mozilla.org/integration/autoland/rev/cf9a7a7f569fafefcbb66ff633dec9068513013e

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/cf9a7a7f569f

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05a98e2570bc
[devtools] Simplify the network request payload r=ochameau

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/05a98e2570bc

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92a054efda22
[devtools] Simplify the network resource payload for the server watcher r=ochameau

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/92a054efda22