1662758 - Make xpcshell-tests in services/settings/test pass when a different bucket is the default

Status: RESOLVED INVALID

(Firefox :: Remote Settings Client, task)

Description

[Mark Banner (:standard8)]

In bug 1612380, we tried changing the services/settings/test to specify a default bucket of main for preferences via the xpcshell.ini:

[DEFAULT]
prefs =
  services.settings.default_bucket=main

This was because Thunderbird has a different default_bucket.

Unfortunately, this broke the tests when running on Android with things like:

[task 2020-09-01T17:35:39.408Z] 17:35:39  WARNING -  TEST-UNEXPECTED-FAIL | services/settings/test/unit/test_attachments_downloader.js | test_downloader_reports_download_errors - [test_downloader_reports_download_errors : 138] parent must be in snapshot. Has []. - false == true
[task 2020-09-01T17:35:39.408Z] 17:35:39     INFO -  resource://testing-common/TelemetryTestUtils.jsm:assertEvents:138
[task 2020-09-01T17:35:39.408Z] 17:35:39     INFO -  test_attachments_downloader.js:test_downloader_reports_download_errors/<:261
[task 2020-09-01T17:35:39.408Z] 17:35:39     INFO -  /data/local/tmp/test_root/xpc/head.js:_do_main:248
[task 2020-09-01T17:35:39.408Z] 17:35:39     INFO -  /data/local/tmp/test_root/xpc/head.js:_execute_test:577
[task 2020-09-01T17:35:39.408Z] 17:35:39     INFO -  -e:null:1
[task 2020-09-01T17:35:39.408Z] 17:35:39     INFO -  exiting test
[task 2020-09-01T17:35:39.409Z] 17:35:39     INFO -  Unexpected exception NS_ERROR_ABORT:
[task 2020-09-01T17:35:39.409Z] 17:35:39     INFO -  _abort_failed_test@/data/local/tmp/test_root/xpc/head.js:833:20
[task 2020-09-01T17:35:39.409Z] 17:35:39     INFO -  do_report_result@/data/local/tmp/test_root/xpc/head.js:934:5
[task 2020-09-01T17:35:39.409Z] 17:35:39     INFO -  Assert<@/data/local/tmp/test_root/xpc/head.js:73:21
[task 2020-09-01T17:35:39.409Z] 17:35:39     INFO -  proto.report@resource://testing-common/Assert.jsm:233:10
[task 2020-09-01T17:35:39.409Z] 17:35:39     INFO -  proto.ok@resource://testing-common/Assert.jsm:259:10
[task 2020-09-01T17:35:39.409Z] 17:35:39     INFO -  assertEvents@resource://testing-common/TelemetryTestUtils.jsm:138:12
[task 2020-09-01T17:35:39.409Z] 17:35:39     INFO -  test_downloader_reports_download_errors/<@test_attachments_downloader.js:261:24
[task 2020-09-01T17:35:39.409Z] 17:35:39     INFO -  _do_main@/data/local/tmp/test_root/xpc/head.js:248:6
[task 2020-09-01T17:35:39.409Z] 17:35:39     INFO -  _execute_test@/data/local/tmp/test_root/xpc/head.js:577:5
[task 2020-09-01T17:35:39.409Z] 17:35:39     INFO -  @-e:1:1
[task 2020-09-01T17:35:39.410Z] 17:35:39     INFO -  exiting test
[task 2020-09-01T17:35:39.410Z] 17:35:39     INFO -  services/settings/test/unit/test_attachments_downloader.js | [27075, Main Thread] WARNING: GetDnsSuffixList is not supported without a bridge connection: file /builds/worker/checkouts/gecko/netwerk/system/android/nsAndroidNetworkLinkService.cpp, line 139
[task 2020-09-01T17:35:39.410Z] 17:35:39     INFO -  services/settings/test/unit/test_attachments_downloader.js | [27075, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp, line 3359
[task 2020-09-01T17:35:39.410Z] 17:35:39     INFO -  services/settings/test/unit/test_attachments_downloader.js | [27075, Main Thread] WARNING: OOPDeinit() without successful OOPInit(): file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp, line 3359
[task 2020-09-01T17:35:39.410Z] 17:35:39     INFO -  services/settings/test/unit/test_attachments_downloader.js | [27075, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp, line 4286
[task 2020-09-01T17:35:39.411Z] 17:35:39     INFO -  services/settings/test/unit/test_attachments_downloader.js | [27075, Main Thread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/checkouts/gecko/xpcom/base/nsTraceRefcnt.cpp, line 202
[task 2020-09-01T17:35:39.411Z] 17:35:39     INFO -  services/settings/test/unit/test_attachments_downloader.js | [27075, Main Thread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/checkouts/gecko/xpcom/base/nsTraceRefcnt.cpp, line 202
[task 2020-09-01T17:35:39.411Z] 17:35:39     INFO -  services/settings/test/unit/test_attachments_downloader.js | [27075, Main Thread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/checkouts/gecko/xpcom/base/nsTraceRefcnt.cpp, line 202

Comment 1

[Mark Banner (:standard8)]

One idea I did just have (but haven't tested), is to put the preference into https://searchfox.org/mozilla-central/source/testing/profiles/xpcshell/user.js

Not sure if that would work for Thunderbird though - it might also end up the same as defining it in xpcshell.ini.

Comment 2

[Mathieu Leplatre [:leplatrem]]

In Bug 1702759 we dropped the default_bucket preference, the default bucket value is now managed as an AppConstant. I will mark this bug as invalid.