1662769 - "printerInfo._resolved;" Expression with no effect

Status: RESOLVED FIXED

(Toolkit :: Printing, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Coverity thinks that this change:
https://hg.mozilla.org/mozilla-central/rev/12b9a9eaa01028206062824f2e585ad1862cf188#l1.92
is useless as it doesn't do anything

Maybe = true is missing?

Comment 1

[Jonathan Watt [:jwatt]]

I'll take this so sfoster can spend his time on the paper size patch. It's a trivial fix anyway.

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: Bug 1662769. Make PrintSettingsViewProxy.resolvePropertiesForPrinter use the saved printer info. r=mstriemer

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d995f20c201
Make PrintSettingsViewProxy.resolvePropertiesForPrinter use the saved printer info. r=mstriemer

Comment 4

[Sam Foster [:sfoster] (he/him)]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #0)

Coverity thinks that this change:
https://hg.mozilla.org/mozilla-central/rev/12b9a9eaa01028206062824f2e585ad1862cf188#l1.92
is useless as it doesn't do anything

Maybe = true is missing?

a tad embarrassing. I think I flubbed this when rebasing. Thanks for spotting and filing.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Sam, this is why we have linter/static analyzers ;)

I wonder why eslint didn't find it.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Mark pointed me to bug 1409693

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/9d995f20c201

Comment 8

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 9173656 [details]
Bug 1662769. Make PrintSettingsViewProxy.resolvePropertiesForPrinter use the saved printer info. r=mstriemer

Beta/Release Uplift Approval Request

• User impact if declined: Printer info is not cached and gets re-queried each time the printer is re-selected in the print destination picker
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1660527
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): New print UI is functional without, this is an optimization.
• String changes made/needed: None

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1660527

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9173656 [details]
Bug 1662769. Make PrintSettingsViewProxy.resolvePropertiesForPrinter use the saved printer info. r=mstriemer

Approved for 81.0b6.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6e5f62666ba7