1662830 - Crash in [@ mozilla::PresShell::EventHandler::HandleEventUsingCoordinates]

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Kevin Brosnan [Ex-Mozilla]]

Reported from https://github.com/mozilla-mobile/fenix/issues/14624

Crash report: https://crash-stats.mozilla.org/report/index/b596f1ce-c8a9-4dfb-9a6e-dceb20200902

Top 10 frames of crashing thread:

0 libxul.so mozilla::PresShell::EventHandler::HandleEventUsingCoordinates layout/base/PresShell.cpp:6990
1 libxul.so mozilla::PresShell::EventHandler::HandleEvent layout/base/PresShell.cpp:6880
2 libxul.so mozilla::PresShell::HandleEvent layout/base/PresShell.cpp:6805
3 libxul.so nsViewManager::DispatchEvent view/nsViewManager.cpp:750
4 libxul.so nsView::HandleEvent view/nsView.cpp:1133
5 libxul.so nsWindow::DispatchEvent widget/android/nsWindow.cpp:2412
6 libxul.so nsBaseWidget::ProcessUntransformedAPZEvent widget/nsBaseWidget.cpp:963
7 libxul.so nsWindow::NPZCSupport::InputEvent<nsWindow::NPZCSupport::HandleMouseEvent widget/android/nsWindow.cpp:761
8 libxul.so nsAppShell::ProcessNextNativeEvent widget/android/nsAppShell.cpp:679
9 libxul.so nsBaseAppShell::OnProcessNextEvent widget/nsBaseAppShell.cpp:259

Comment 1

[Boris Chiou [:boris]]

It seems only two crashes in 80, but a lot of in Fenix. mark S2 for now.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

This is the mExitFrom.value() call https://hg.mozilla.org/mozilla-central/file/b4055ac79297914c4b33dde0c7832fe63a5d5787/layout/base/PresShell.cpp#l6990

Comment 3

[Edgar Chen [:edgar]]

This presumably is caused by https://phabricator.services.mozilla.com/D88225. mExitFrom should not be Nothing() at this point.

Comment 4

[Edgar Chen [:edgar]]

Attachment: Bug 1662830 - Initialize mExitFrom in MouseInput::ToWidgetMouseEvent;

This is missed in https://phabricator.services.mozilla.com/D88225.
MouseInput::ToWidgetMouseEvent is used only in Android.

Comment 5

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1653949

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/493274bb362f
Initialize mExitFrom in MouseInput::ToWidgetMouseEvent; r=smaug

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/493274bb362f