1662845 - 0 sheets of paper is shown while loading print settings

Status: RESOLVED FIXED

(Toolkit :: Printing, defect, P1)

Description

[Mark Striemer [:mstriemer]]

The sheet count is no longer being hidden when the dialog is initializing. Adding a rendering attribute to the body should fix this.

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1662845 - Hide sheet count while loading print dialog r?sfoster

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6048ae9b6b23
Hide sheet count while loading print dialog r=sfoster

Comment 3

[Mark Striemer [:mstriemer]]

Comment on attachment 9173779 [details]
Bug 1662845 - Hide sheet count while loading print dialog r?sfoster

Beta/Release Uplift Approval Request

• User impact if declined: Misleading text is shown about the number of sheets required while the print dialog is loading.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This just initializes the "rendering" property in the HTML file so it's set on the initial load, rather than waiting until the JS runs the code to render the preview.
• String changes made/needed: No

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/6048ae9b6b23

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9173779 [details]
Bug 1662845 - Hide sheet count while loading print dialog r?sfoster

Approved for 81.0b6.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b8e31b1e7ad4