1662850 - Remove address-space segments from diffs

Status: RESOLVED FIXED

(Toolkit :: about:memory, task, P3)

Description

[Andrew McCreight [:mccr8]]

The segment numbers under address-space vary and just introduce a lot of noise:

│ ├──-20,889,600 B (100.0%) ── readwrite(segments=93) [2] [-]
│ ├──20,262,912 B (100.0%) ── readwrite(segments=87) [2] [+]

I suppose a more clever way to deal with it would be to do a diff on the number of segments, but scrubbing them sounds easier.

Comment 1

[Andrew McCreight [:mccr8]]

Here's what the diff looks like with my changes:

0.00 MB (100.0%) -- address-space
├──243.32 MB (100.0%) -- commit
│ ├──240.57 MB (100.0%) -- mapped
│ │ ├──240.94 MB (100.0%) ── readonly(segments=NNNN) [8]
│ │ └───-0.37 MB (100.0%) ── noaccess(segments=NNNN) [8]
│ ├────3.00 MB (100.0%) -- private
│ │ ├──3.02 MB (100.0%) ── readwrite(segments=NNNN) [8]
│ │ ├──-0.06 MB (100.0%) ── execute-read(segments=NNNN) [8]
│ │ └──0.04 MB (100.0%) ── readwrite+stack(segments=NNNN) [8]

You can now more clearly see the actual changes in the different types of address space.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1662850 - Remove address-space segments from diffs.

These segment counts vary as memory usage vary, which makes diffs a lot
noisier. It would be slicker to diff the number of segments, but that
would require some changes to the way we do diffs.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d722f92092a
Remove address-space segments from diffs. r=njn

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6d722f92092a