1662939 - Wait for print preview to be initialized before printing or opening system dialog

Status: VERIFIED FIXED

(Toolkit :: Printing, task, P1)

Description

[Emma Malysz]

When the print preview is loading, the user should not be able to print the page. It looks like this may have intermittent problems. The user should also not be able to click on the "open with system dialog" link, as it will populate with incorrect settings (such as only being able to print 1 blank page).

These should be disabled/unclickable until the "rendering" attribute is removed https://searchfox.org/mozilla-central/source/toolkit/components/printing/content/print.js#454

For reference, https://fr.wikipedia.org/wiki/Gr%C3%A8ce is a page that takes a while to render.

Comment 1

[Emma Malysz]

Attachment: Bug 1662939, disable form if user prints or opens system dialog when preview is rendering.

Comment 2

[Emma Malysz]

ni? shorlander and going to hold off until he decides on how we should proceed with the system dialog portion

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4d6a8242c68
disable form if user prints or opens system dialog when preview is rendering. r=mstriemer

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e4d6a8242c68

Comment 5

[Vlad Lucaci, Desktop QA (:vlucaci)]

Hello,

I have tried to verify this issue in 82.0(20201012131351) and 83.0a1(20201013094053) with macOS 10.15.7, Ubuntu 18.04 and Win10x64, and the buttons can still be interacted with while the print preview is loading.

The only instance where the Cancel and Print buttons are greyed out and cannot be interacted with, is when selecting "print using the system dialog" button , while the preview is loading.

Comment 6

[Emma Malysz]

Sorry, Vlad. We decided on a different approach, so I updated the bug summary.

The user should be able to interact with the cancel/print/system dialog buttons while the preview is loading. If the user clicks on the print/save button or the system dialog button, the form should then be disabled. We wait for the preview to finish rendering, and then we complete the action.

Comment 7

[Vlad Lucaci, Desktop QA (:vlucaci)]

Confirming the above behavior on 84.0b2(20201117192430) and 85.0a1(20201118215158). Verified using Ubuntu 20.04, macOS 10.15.7 and Win10x64.