1662979 - Add support for OAuth2 CardDAV providers

Status: RESOLVED FIXED

(MailNews Core :: Address Book, enhancement, P1)

Description

[Geoff Lankow (:darktrojan)]

Our CardDAV implementation currently only supports HTTP authentication, but Google use OAuth. I have the code ready to support Google, but we are waiting for them to allow us to ask the user for permission. Yahoo probably use OAuth, although I haven't looked into it yet.

Comment 1

[Wayne Mery (:wsmwk)]

affects 80k users if the numbers are correct at https://addons.thunderbird.net/en-US/thunderbird/addon/gcontactsync/

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1662979 - Add support for OAuth2 CardDAV providers. r?mkmelin

So far, this will only work for Google CardDAV, but I've included the fixes for dealing with the
Yahoo! server's idiosyncrasies, so that when the time comes, all we have to do is add the Yahoo!
details to OAuth2Providers.jsm.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bede4f709203
Add support for OAuth2 CardDAV providers. r=mkmelin

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9190676 [details]
Bug 1662979 - Add support for OAuth2 CardDAV providers. r?mkmelin

[Approval Request Comment]
User impact if declined: this allows users to contact sync with Google again
Testing completed (on c-c, etc.): in beta 85
Risk to taking this patch (and alternatives if risky): it's behind a pref and clearly marked as experimental

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9190676 [details]
Bug 1662979 - Add support for OAuth2 CardDAV providers. r?mkmelin

[Triage Comment]
Approved for esr78

Comment 6

[Dave Miller [:justdave]]

This patch does not apply cleanly to esr78 and the conflicts are things that I don't feel safe manually merging. Can you respin the patch for esr78?

Comment 7

[Geoff Lankow (:darktrojan)]

See https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=e39c84abd9c0421bc2fa5c9ad6da315fd2195cab for landing order.

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.7.1:
https://hg.mozilla.org/releases/comm-esr78/rev/0ca2c34a1824