Closed Bug 1663 Opened 22 years ago Closed 18 years ago

string usage inconsistent between DOM and XPIDL

Categories

(Core :: DOM: Core & HTML, defect, P2)

x86
Windows NT
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: peterl-retired, Assigned: scc)

References

Details

(Keywords: dom1)

in use of pointers versus references for out paramaters. We need to pick a
standard and use it.
Also, get methods could/should be made const. (We may need to override this for
certain methods.)
Status: NEW → ASSIGNED
Setting all current Open/Normal to M4.
per leger, assigning QA contacts to all open bugs without QA contacts according
to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser
Target Milestone: M4 → M6
Target Milestone: M6 → M8
I know, I know. I need to deal with this sooner rather than later. Still pushing
off till M8.

Should also look into switching over to using nsIString.
Target Milestone: M8 → M10
I'm not happy with the way things are going with the wstring/nsIString debate. I
still want that issue to be better resolved.
Blocks: 6052
Assignee: vidur → brendan
Status: ASSIGNED → NEW
Target Milestone: M10 → M11
Brendan and vidur are doing the ``[shared] wstring'' surgery on the DOM
interfaces, so I'm giving this to brendan.
Target Milestone: M11 → M12
Balancing my M-numbers.

/be
Target Milestone: M12 → M14
After beta.

/be
Target Milestone: M14 → M16
Pushing to after beta, for sure.

/be
Scott, can I give this bug to you for keeping and possibly fixing while I'm on 
sabbatical?  Vidur and I haven't done the [shared] evil yet.  Cc'ing vidur and 
waterson.

/be
Assignee: brendan → scc
Status: ASSIGNED → NEW
Summary: IDL generated interfaces inconsistent → string usage inconsistent between DOM and XPIDL
Sure, no problem.
Status: NEW → ASSIGNED
Hmmm.  Well, the new string interfaces are going to make it easy and pleasant to 
use just a |char*| or a |PRUnichar*| as a interface type for crossing [XP]COM 
boundaries.  Essentially, the thing that was |nsXPIDL[C]String| will be a full 
member of the string hierarchy and useable in the same way that |nsString| is.  
So my recommendation for passing strings across boundaries is to use raw 
pointers but then in C++ code, collect them into (the new equivalent of) an 
|nsXPIDL[C]String|.  I think this is the best of both worlds ... compatibility 
and functionality.
With respect to the initial description: I think the general decision has been 
pointers for out-parameters, and though some people are still using non-|const| 
references, we are gradually weeding them out.  Similarly with marking all 
getters |const|.  I assume you are not just talking about strings here, but the 
app as whole.
Target Milestone: M16 → M18
mass re-assigning to my new bugzilla account
Assignee: scc → scc
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Moving up based on the `new porkjockey's' architecture meeting.
Target Milestone: M18 → M17
QA Contact: gerardok → janc
Mass update of qa contact
Target Milestone: M17 → ---
Keywords: dom1
Component: DOM Level 1 → DOM Core
QA contact Update
QA Contact: janc → desale
Updating QA contact to Shivakiran Tummala.
QA Contact: desale → stummala
closing this bug because I think it no longer applies.  The string scheme for
the DOM is in place and there are no recent complaints.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Component: DOM: Core → DOM: Core & HTML
QA Contact: stummala → general
You need to log in before you can comment on or make changes to this bug.