1663037 - Improve OpenPGP key import failure scenarios

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, enhancement, P1)

Description

[Kai Engert [:KaiE:]]

Users run into problems when importing keys.
We have several reports for scenarios we don't understand yet, examples are bug 1658187 and bug 1662984.

While we don't know the cause yet, let's try to improve our handling of import failures.

One symtpom is is: Import seems stuck.
Reason is that we get an exception, and the UI flow is interrupted and never proceeds.
We should add try/catch blocks to ensure we notice the problem and tell the user.

I've see that after an import failure, using the cancel button in the import wizard no longer works. It seems the kGenerating variable isn't reset properly.

Another report was:
When being prompted to enter the password for a secret key, we only show the fingerprint as identifying criteria, which makes it difficult for the user to know which key the prompt is about. To improve this, I think we can simply append the key's user ID and its creation date to the shown key identifier in the prompt.

We got reports that saving keys to files was impossible. Let's improve the error message with the exact path that we tried to save to, in the hope this will allow the users give us better information, and to possibly self-diagnose (by reading the error console).

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Bug 1663037 - Improve OpenPGP key import failure scenarios. r=aleca

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/584545287aa2
Improve OpenPGP key import failure scenarios. r=aleca DONTBUILD

Comment 3

[Kai Engert [:KaiE:]]

Comment on attachment 9173866 [details]
Bug 1663037 - Improve OpenPGP key import failure scenarios. r=aleca

OpenPGP correctness, only effect should be better handling of failure scenarios.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9173866 [details]
Bug 1663037 - Improve OpenPGP key import failure scenarios. r=aleca

[Triage Comment]
Approved for beta

Comment 5

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/releases/comm-beta/rev/125711ac084da4fd969a889bc20d4b53e66b8670
81.0b3

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9173866 [details]
Bug 1663037 - Improve OpenPGP key import failure scenarios. r=aleca

[Triage Comment]
Approved for esr78.

Comment 7

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/releases/comm-esr78/rev/e85591b838e8549ab180cdb756a32696d784561b
78.2.2