1663040 - Paper-size menu in the new print UI should be sorted by name

Status: VERIFIED FIXED

(Toolkit :: Printing, enhancement, P2)

Description

[Jonathan Kew [:jfkthame]]

Attachment: Screenshot of paper size drop-down

The paper size menu in the tab-modal print UI lists available paper sizes in what looks at first like a random order; see attachment.

(I think it may not actually be random, but sorted by the length of the longer side? Or by total area of the paper? I haven't checked exact details.... the point is that it looks scrambled from a user's point of view.)

It would be much more user-friendly to sort by paper name, so that all the A-sizes appear together, all the B-sizes, all Envelope-* sizes, all "US ..." sizes, etc.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1663040 - Sort available paper sizes by name for the menu in the print UI. r=sfoster

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b988903df22
Sort available paper sizes by name for the menu in the print UI. r=jwatt

Comment 3

[Jonathan Kew [:jfkthame]]

Comment on attachment 9174023 [details]
Bug 1663040 - Sort available paper sizes by name for the menu in the print UI. r=sfoster

Beta/Release Uplift Approval Request

• User impact if declined: Paper sizes in the new printing UI appear in a confusing "random" order
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
  • Open the Print panel
  • Click on More Settings
  • Open the Paper Size menu and see if the list is sensibly ordered
    (Try with different printers selected, as the list is printer-specific)
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just adding a .sort() call to order the paper list
• String changes made/needed:

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8b988903df22

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9174023 [details]
Bug 1663040 - Sort available paper sizes by name for the menu in the print UI. r=sfoster

Approved for 81.0b8.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/651834ef16e6

Comment 7

[Vlad Lucaci, Desktop QA (:vlucaci)]

Confirming this issue as verified fixed on macOS 10.15, Ubuntu 18.04 and Windows 10x64. Verified using 82.0a1 (2020-09-09) and 81.0b8.