1663068 - [wpt-sync] Sync PR 25397 - Force colors at the end of the cascade

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 25397 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25397
Details from upstream follow.

b'Alison Maher <[e-mail]>' wrote:

Force colors at the end of the cascade

As resolved by the CSSWG [1], we should respect system color rules
set by the author/user in Forced Colors Mode. This CL is the second
of several changes to make this happen.

Currently, in order to force colors in Forced Colors Mode, we revert
the related properties at the author origin. This logic is now removed
from the spec [2].

To accommodate the above changes, the plan is to simulate a revert at
the end of the cascade, but only if the computed value for a given
property is not already a system color and forced-color-adjust is set
to auto.

This CL moves the logic for reverting properties that are affected
by Forced Colors Mode to the end of the cascade using the
ForceColors() method (which was added here [3]).

[1] https://github.com/w3c/csswg-drafts/issues/4178
[2] https://github.com/w3c/csswg-drafts/commit/7c154ddc7f196df9b40a34a5f63bf6d157b1011b
[3] https://chromium-review.googlesource.com/c/chromium/src/+/2376666

Bug: 970285
Change-Id: I5039fdaf5ce6d5917a258e593fb2f527581c72e1
Reviewed-on: https://chromium-review.googlesource.com/2388991
WPT-Export-Revision: 4f83ff9ef8ed1d6ab29f3b63f75a9e34b3574573

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9081804dd515946487df62d1fcd991a25c062e1a

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee3285989505878fc2fbb48b8bfc49291f5c9a94

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/forced-colors-mode/forced-colors-mode-28.html: FAIL (Chrome: FAIL, Safari: FAIL)