166308 - remove some XUL debugging printf's

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Alec Flett]

so I found about 4k of code (compiled) which prints out debugging information
for XUL even on release builds. I was able to remove it all quite easily with a
bunch of #ifdef NS_DEBUG.. patch forthcoming

Comment 1

[Alec Flett]

Attachment: remove debugging code with NS_DEBUG

Here's the patch. who wants to review? it's really easy.

Comment 2

[Brian Ryner (not reading)]

Comment on attachment 97571 [details] [diff] [review]
remove debugging code with NS_DEBUG

The main call site for DumpBox is #ifdef DEBUG_LAYOUT, should we use the same
#ifdef here?

Comment 3

[Alec Flett]

Attachment: remove debugging code with DEBUG_LAYOUT

an excellent point. new patch attached using DEBUG_LAYOUT instead. I also moved
the commented out "//#define DEBUG_LAYOUT" out of nsBox.cpp and into nsIBox.h,
since thats the central place where this is all kicked off

Comment 4

[Alec Flett]

can I get a r=bryner, sr=jag?

Comment 5

[Brian Ryner (not reading)]

Comment on attachment 98188 [details] [diff] [review]
remove debugging code with DEBUG_LAYOUT

r=bryner

Comment 6

[jag (Peter Annema)]

Comment on attachment 98188 [details] [diff] [review]
remove debugging code with DEBUG_LAYOUT

sr=jag

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 98188 [details] [diff] [review]
remove debugging code with DEBUG_LAYOUT

a=asa (on behalf of drivers) for checkin to 1.2a

Comment 8

[Alec Flett]

fix is in.