1663085 - [wpt-sync] Sync PR 25398 - regression fix: non-auto table sizing inside flexbox

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 25398 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25398
Details from upstream follow.

b'Aleks Totic <[e-mail]>' wrote:

regression fix: non-auto table sizing inside flexbox

https://chromium-review.googlesource.com/c/chromium/src/+/2214895
introduced a change where LayoutTable started respecting
OverrideLogicalWidth for flex items.

This broke rendering of non-auto tables inside flexbox.

The fix has 2 parts:

1. LayoutTable::UpdateLogicalWidth always respects OverrideLogicalWidth
2. FlexLayoutAlgorithm::ShouldApplyMinSizeAutoForChild returns true
   for tables.

Another side effect of this fix is that the TablesNG flexbox hack
is no longer needed.
https://chromium-review.googlesource.com/c/chromium/src/+/1730138/167/third_party/blink/renderer/core/layout/ng/flex/ng_flex_layout_algorithm.cc

Bug: 1123100
Change-Id: Ide428db79a3d9b26e426c6f7727349549ea40836
Reviewed-on: https://chromium-review.googlesource.com/2392444
WPT-Export-Revision: 0b294b59825c2b67fa3e3b9e0eea8e525e7a66b4

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f1d13ec1efb7343164bb0042a189d38e8dc0b19

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
FAIL: 2

Safari

OK : 1
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-flexbox/table-with-percent-intrinsic-width.html
table 1: FAIL (Chrome: FAIL, Safari: FAIL)
table 2: FAIL (Chrome: FAIL, Safari: FAIL)