Remove workaround for intermittently failing updater failures when compiled with mingw-w64
Categories
(Toolkit :: Application Update, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: gk, Assigned: me)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
In bug 1561636 we upstreamed a patch that worked around mingw-w64 bugs in _ftelli64/_fseeki64. Both of them were implemented and used in mingw-w64 in an msvrct scenario, which we were dealing with back then. They are not relevant in an ucrt-based environment which we are using now (see jacek's comment in: https://trac.torproject.org/projects/tor/ticket/26514#comment:19).
In fact, as cpeterson noted in https://bugzilla.mozilla.org/show_bug.cgi?id=1656285#c4, once we use the ucrt, using ftello64 and fseeko64 instead of the ones above is kind of meaningless as they are implemented by _ftelli64 and _fseeki64 respectively.
Thus, we can remove the workaround I think.
|
||
Updated•4 years ago
|
|
|
||
Comment 3•4 years ago
|
||
Comment on attachment 9183577 [details]
Bug 1663119 - Remove mingw workaround for COMPOSITIONOBJECT_ALL_ACCESS r?tjr
Revision D94659 was moved to bug 1664365. Setting attachment 9183577 [details] to obsolete.
Pushed by tritter@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9dc165932ca9 Remove mingw workaround for _ftelli64/_fseeki64 r=tjr
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Description
•