1663122 - Pocket fails to add tags from URL bar button

Status: RESOLVED DUPLICATE of bug 1663028

(Firefox :: Pocket, defect, P1)

Description

[Fanolian]

Attachment: Browser Console output when I add a tag.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:82.0) Gecko/20100101 Firefox/82.0
Build ID: 20200903151816

Steps to reproduce

1. In a new profile, log in to Pocket from https://app.getpocket.com/
2. Open a new tab, visit any site. (Actually you can use the same Pocket tab.)
3. Click the Save to Pocket button on the URL bar.
   In the Add Tags field, enter any tag. (You don't have to pre-create a tag; it will create one for you)
4. Press Save.
5. Go back to Pocket tab and observe the newly added item.

Actual result

The item is added but without the assigned tag. In Browser Console this error is generated when I press Save:
(see the attached screenshot for better formatting)

Uncaught TypeError: can't access property "apiRequest", this is undefined    pktApi.jsm:522:5
    sendActions chrome://pocket/content/pktApi.jsm:522
    sendAction chrome://pocket/content/pktApi.jsm:511
    addTags chrome://pocket/content/pktApi.jsm:610
    addTagsToURL chrome://pocket/content/pktApi.jsm:562
    registerEventMessages chrome://pocket/content/main.js:607
    addMessageListener chrome://pocket/content/main.js:813
    sendMessage chrome://pocket/content/panels/js/messages.js:67
    sendMessage chrome://pocket/content/panels/js/saved.js:632
    initAddTagInput chrome://pocket/content/panels/js/saved.js:378
    jQuery 8
        dispatch
        handle
        add
        on
        each
        each
        on
        b
    initAddTagInput chrome://pocket/content/panels/js/saved.js:354
    create chrome://pocket/content/panels/js/saved.js:597
    create chrome://pocket/content/panels/js/saved.js:660
    <anonymous> chrome://pocket/content/panels/js/saved.js:722
    responseListener chrome://pocket/content/panels/js/messages.js:53
    addMessageListener chrome://pocket/content/panels/js/messages.js:26
    sendMessageToPanel chrome://pocket/content/main.js:848
    sendResponseMessageToPanel chrome://pocket/content/main.js:853
    registerEventMessages chrome://pocket/content/main.js:671
    addMessageListener chrome://pocket/content/main.js:813
    sendMessage chrome://pocket/content/panels/js/messages.js:67
    sendMessage chrome://pocket/content/panels/js/saved.js:632
    <anonymous> chrome://pocket/content/panels/js/saved.js:708
    jQuery 8
        j
        fireWith
        ready
        I
        promise
        <anonymous>
        <anonymous>
        <anonymous>

Expected result

A tag is assigned to the newly added item.

Notes

1. I can still create or assign tags from Pocket's page. It does not work only from Firefox's URL bar button.
2. I log in to my Pocket account by email, not a Firefox Account.
3. Relevant locale settings according to about:support:

Internationalization & Localization

Application Settings
Requested Locales 	["en-US"]
Available Locales 	["en-US"]
App Locales 	["en-US"]
Regional Preferences 	["en-HK"]
Default Locale 	"en-US"

Operating System
System Locales 	["en-US","zh-Hant-HK"]
Regional Preferences 	["en-HK"]

Comment 1

[Fanolian]

From Mozregression:
Last good Nightly: 2020-09-01
First bad Nightly: 2020-09-02
pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4a18696ce81f949bd4fea1a68966a4e335d8fbad&tochange=aa032cbc94551a0f6e7e821d78aa0388f998e830

Bisecting autoland builds:
pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5d7a942097d6e992ed52350a0957374c4ee6129f&tochange=858282dd490f7cc3001fb76fd1be715c139fa357

It is regressed by bug 1655124.

Comment 2

[Fanolian]

[Tracking Requested - why for this release]:
It severely affects the workflow for Pocket users. Also the Save to Pocket button is one of few visible by default buttons in the URL bar.

Comment 3

[Fanolian]

Additional note

The issue is present whether extensions.pocket.onSaveRecs is true or false.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1655124

Comment 5

[Scott [:thecount] Downe]

Should be fixed in bug 1663028

Comment 6

[Julien Cristau [:jcristau]]

Fanilian can you verify this in today's nightly (build id 20200911093056)?

Comment 7

[Fanolian]

(In reply to Julien Cristau [:jcristau] from comment #6)

Fanilian can you verify this in today's nightly (build id 20200911093056)?

Fixed in 20200911093056. Thanks a lot.