1663184 - Remote Settings controlled Topsites(with search engines available) can be set as search shortcuts

Status: RESOLVED WORKSFORME

(Firefox :: Top Sites, defect)

Description

[Adrian Florinescu [:aflorinescu]]

[Sugested Severity:]

S3

[Description:]

My understanding is that all topsites with corresponding search engines should be settable as search shortcuts.

[Environment:]

Mac 10.14.6 / Windows 10
81.0b6 20200903205131

[Steps:]

1. Add https://baidu.com as a topsite in the Remote Settings configuration.
2. From the Remote Settings configuration, set https://baidu.com to be a search shortcut.
3. Publish the changes and set Firefox to connect to the respective collection.
4. Set an Firefox profile to connect to the configuration while switching the browser.topsites.useRemoteSetting to true.
5. Start-up Firefox with the above profile configuration.

[Actual Result:]

baidu is listed just as a default topsite.

[Expected Result:]

baidu is listed as a topsite, being a search shortcut and marked as such.

[Note:]
If the above steps are done for amazon or google, it works as expected.

Comment 1

[Dão Gottwald [:dao]]

I think bug 1661008 may have fixed this. Could you please check again?

Comment 2

[Adrian Florinescu [:aflorinescu]]

I think this might be an invalid bug if my revised assumptions are correct: we do not want to set a search shortcut unless the search engine is builtin and active -> see https://bugzilla.mozilla.org/show_bug.cgi?id=1661008#c10

Comment 3

[Dão Gottwald [:dao]]

(In reply to Adrian Florinescu [:aflorinescu] from comment #2)

I think this might be an invalid bug if my revised assumptions are correct: we do not want to set a search shortcut unless the search engine is builtin and active -> see https://bugzilla.mozilla.org/show_bug.cgi?id=1661008#c10

That's right.

Comment 4

[Adrian Florinescu [:aflorinescu]]

Thank you for the confirmation. Closing this down as WFM:
-search shortcuts should be only set when the engine is builtin and active.