Closed Bug 1663260 Opened 3 months ago Closed 2 months ago

Support Number toString and String toString/valueOf in CacheIR

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: evilpie, Assigned: evilpie)

Details

Attachments

(3 files)

No description provided.
Assignee: nobody → evilpies
Status: NEW → ASSIGNED
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2c9b6db1868b
Support primitive String toString and valueOf in CacheIR. r=anba
https://hg.mozilla.org/integration/autoland/rev/f6329f10fe5c
Support primitive Number toString in CacheIR. r=anba
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

Hi Tom, I've missed one small issue in the review for https://phabricator.services.mozilla.com/D89308. num_toString wasn't changed to JS_INLINABLE_FN, so the new inlining path is never used. :-)

Flags: needinfo?(evilpies)
Status: RESOLVED → REOPENED
Flags: needinfo?(evilpies)
Resolution: FIXED → ---

I also added a test that I forgot to commit last time.

Good catch André. I also never added the test file apparently.

Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/81591091e876
Actually mark Number.prototype.toString as an inlinable function. r=anba
Status: REOPENED → RESOLVED
Closed: 3 months ago2 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.