1663260 - Support Number toString and String toString/valueOf in CacheIR

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1663260 - Support primitive String toString and valueOf in CacheIR. r?anba

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1663260 - Support primitive Number toString in CacheIR. r?anba

Depends on D89307

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c9b6db1868b
Support primitive String toString and valueOf in CacheIR. r=anba
https://hg.mozilla.org/integration/autoland/rev/f6329f10fe5c
Support primitive Number toString in CacheIR. r=anba

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2c9b6db1868b
https://hg.mozilla.org/mozilla-central/rev/f6329f10fe5c

Comment 5

[André Bargull [:anba]]

Hi Tom, I've missed one small issue in the review for https://phabricator.services.mozilla.com/D89308. num_toString wasn't changed to JS_INLINABLE_FN, so the new inlining path is never used. :-)

Comment 6

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1663260 - Actually mark Number.prototype.toString as an inlinable function. r?anba

I also added a test that I forgot to commit last time.

Comment 7

[Tom S. (please needinfo tschuster)]

Good catch André. I also never added the test file apparently.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81591091e876
Actually mark Number.prototype.toString as an inlinable function. r=anba

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/81591091e876