1663262 - Very high memory usage while deleting large chunks of browsing history

Status: NEW

(Toolkit :: Data Sanitization, defect, P3)

Description

[stefanel.stan]

Attachment: firefox_critical_memory_leak.PNG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:80.0) Gecko/20100101 Firefox/80.0

Steps to reproduce:

Steps to reproduce:

1. Open browsing history (CTRL + H)
2. Delete browsing history for 1 past month (eg: June)
3. When June is no longer listed, delete July month browsing history

Actual results:

After step #3, Mozilla Firefox begins having a critical memory leak, ramping the used memory even up to 11GB (I had to end the process manually)

Expected results:

Mozilla should have deleted the browsing history (which can take maybe up to 5 seconds) and return to normal.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Marco Bonardo [:mak]]

This is not a memory leak, it's high memory usage. It's likely related to bug 734643.

Do you have add-ons that may be listening to history changes? Could you please attach a log from about:support?

Comment 3

[gwarser]

Probably also bug 1626612. It was hidden because attached memory reports were not anonymized correctly (this bug was fixed).

Sample:

2,301.07 MB (100.0%) -- explicit
├──1,114.65 MB (48.44%) -- network
│  ├──1,114.24 MB (48.42%) -- cache2
│  │  ├──1,093.48 MB (47.52%) ── disk-storage(<anonymized>) [228]
│  │  └─────20.76 MB (00.90%) -- (4 tiny)
│  │        ├──10.14 MB (00.44%) ── memory-storage(<anonymized>) [11]
│  │        ├───4.69 MB (00.20%) ── io
│  │        ├───3.04 MB (00.13%) ── index
│  │        └───2.89 MB (00.13%) ── service
│  └──────0.42 MB (00.02%) ++ (4 tiny)
├────720.08 MB (31.29%) ── heap-unclassified
├────206.12 MB (08.96%) -- js-non-window

Comment 4

[Marco Bonardo [:mak]]

History is unrelated to the network cache though...

Comment 5

[gwarser]

Attachment: memory-report.json.gz

(In reply to Marco Bonardo [:mak] from comment #4)

History is unrelated to the network cache though...

Yet, I can still reproduce by "forgetting about" Gmail from History sidebar.

Comment 6

[Marco Bonardo [:mak]]

Forgetting a site does not just remove history, it also clears the cache, cookies and a bunch of other information:
https://searchfox.org/mozilla-central/rev/5a1a34953a26117f3be1a00db20c8bbdc03273d6/toolkit/components/cleardata/nsIClearDataService.idl#256-261

So this is pretty much both bug 734643 and some high memory usage when clearing the cache.
Honza, do you know of an existing bug about high memory usage when removing things from the cache?

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit auto_nag documentation.