Break up jsfriendapi.h into discrete headers
Categories
(Core :: JavaScript Engine, task, P3)
Tracking
()
People
(Reporter: Waldo, Unassigned)
References
Details
(Keywords: leave-open)
Attachments
(15 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
jsfriendapi.h is a dumping ground. But worse than that, it's a dumping ground that regularly changes, and every change tends to mean the world needs to be rebuilt. (StringType.h and gc/Tracer.h have apparently razor-thin dependencies on it, as the lowest-level users I've yet found. NativeObject.h is another user that probably pretty well poisons the well.) It should be split up into subject-specific headers, and some parts of it are perfectly worthy of promotion to regular ol' public API that's as stable as anything else public.
I've got a bunch of patches which don't fully do this, but they trim off some solid chunks of it. Dunno how long the whole thing will take, but they make a good start.
|
Reporter | |
Comment 1•4 years ago
|
||
|
|
Reporter | |
Comment 2•4 years ago
|
||
Depends on D89330
|
|
Reporter | |
Comment 3•4 years ago
|
||
Depends on D89331
|
|
Reporter | |
Comment 4•4 years ago
|
||
Depends on D89332
|
|
Reporter | |
Comment 5•4 years ago
|
||
Depends on D89333
|
|
Reporter | |
Comment 6•4 years ago
|
||
Depends on D89334
|
|
Reporter | |
Comment 7•4 years ago
|
||
Depends on D89335
Pushed by jwalden@mit.edu: https://hg.mozilla.org/integration/autoland/rev/d77193517dc5 Create a new js/public/String.h header seeded with the inline string functions previously found in jsfriendapi.h. (More functions ought be added/moved here, but these make a good start.) r=jandem,geckoview-reviewers,agi https://hg.mozilla.org/integration/autoland/rev/1b452e9cdd96 Move |XrayJitInfo| functionality to its own friend header. r=jandem https://hg.mozilla.org/integration/autoland/rev/0426b064615e Move |JSJitInfo| out of jsfriendapi.h to its own experimental header. r=jandem https://hg.mozilla.org/integration/autoland/rev/08dc45f7b61c Move various Object-related functions to a new js/public/Object.h header. r=jandem https://hg.mozilla.org/integration/autoland/rev/fe6e573c4ad1 Move allocation-logging functions and |JS_COUNT_{CTOR,DTOR}| into a separate header. r=jandem https://hg.mozilla.org/integration/autoland/rev/d554007fd1dd Move JSM environment-related functionality to its own header. r=jandem https://hg.mozilla.org/integration/autoland/rev/71ed820a5be0 Move DOM proxy-related details (including expand support) to separate headers out of jsfriendapi.h. r=jandem
|
|
Reporter | |
Updated•4 years ago
|
|
||
Comment 9•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d77193517dc5
https://hg.mozilla.org/mozilla-central/rev/1b452e9cdd96
https://hg.mozilla.org/mozilla-central/rev/0426b064615e
https://hg.mozilla.org/mozilla-central/rev/08dc45f7b61c
https://hg.mozilla.org/mozilla-central/rev/fe6e573c4ad1
https://hg.mozilla.org/mozilla-central/rev/d554007fd1dd
https://hg.mozilla.org/mozilla-central/rev/71ed820a5be0
|
|
Reporter | |
Comment 10•4 years ago
|
||
|
|
Reporter | |
Comment 11•4 years ago
|
||
Depends on D92167
|
||
Comment 12•4 years ago
|
||
Pushed by jwalden@mit.edu: https://hg.mozilla.org/integration/autoland/rev/b6e8a7a7b875 Move Intl extras functionality (Mozilla extensions, standardized-but-not-stable/shippable-yet) to namespace JS, improve comments, and make various styling tweaks. r=jandem https://hg.mozilla.org/integration/autoland/rev/220512fd6767 Move Intl functionality out of jsfriendapi.h to a new header. r=jandem
|
||
Comment 13•4 years ago
|
||
Backed out 2 changesets (bug 1663365) for SM bustage at jsfriendapi.cpp.
https://hg.mozilla.org/integration/autoland/rev/8eebea7a78cee569cd1cdb8f0b0539d1a0c9afde
Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317464768&repo=autoland&lineNumber=3277
|
|
||
Comment 14•4 years ago
|
||
Pushed by jwalden@mit.edu: https://hg.mozilla.org/integration/autoland/rev/1ea8f7901c1f Move Intl extras functionality (Mozilla extensions, standardized-but-not-stable/shippable-yet) to namespace JS, improve comments, and make various styling tweaks. r=jandem https://hg.mozilla.org/integration/autoland/rev/5859377d6cd9 Move Intl functionality out of jsfriendapi.h to a new header. r=jandem
|
||
Comment 15•4 years ago
|
||
| bugherder | ||
|
|
Reporter | |
Updated•4 years ago
|
|
|
Reporter | |
Comment 16•4 years ago
|
||
|
|
||
Comment 17•4 years ago
|
||
Pushed by jwalden@mit.edu: https://hg.mozilla.org/integration/autoland/rev/394718eef505 Don't include "js/friend/ErrorMessages.h" in jsfriendapi.h. r=arai
|
|
Reporter | |
Comment 18•4 years ago
|
||
|
|
||
Comment 19•4 years ago
|
||
Pushed by jwalden@mit.edu: https://hg.mozilla.org/integration/autoland/rev/0dce693b75d2 Followup jsglue.cpp fix.
|
||
Comment 20•4 years ago
|
||
| bugherder | ||
|
|
Reporter | |
Comment 21•4 years ago
|
||
|
|
Reporter | |
Comment 22•4 years ago
|
||
Depends on D95670
|
|
Reporter | |
Comment 23•4 years ago
|
||
Depends on D95671
|
|
||
Comment 24•4 years ago
|
||
Pushed by jwalden@mit.edu: https://hg.mozilla.org/integration/autoland/rev/65fe0b522296 Various stylistic cleanups to ctypes-related functionality in jsfriendapi.h, in advance of a move into a separate header. r=jandem https://hg.mozilla.org/integration/autoland/rev/2fba8c0952af Move ctypes APIs out of jsfriendapi.h into a new js/public/experimental/CTypes.h header. r=jandem https://hg.mozilla.org/integration/autoland/rev/5c172e4faf1d Move CTypes APIs out of jsapi.h and into js/public/experimental/CTypes.h. r=jandem
|
||
Comment 25•4 years ago
|
||
| bugherder | ||
|
||
Comment 27•3 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:sdetar, maybe it's time to close this bug?
|
|
Reporter | |
Comment 28•3 years ago
|
||
|
|
Reporter | |
Comment 29•3 years ago
|
||
Still a valid bug. Could conceivably be closed and work just parceled out to individual bugs, but works as well as anything to keep using this.
I dunno how much juice I have for too much these days, but I might churn out some more of these here. Nice break for the mind and all.
|
|
||
Comment 30•3 years ago
|
||
Pushed by jwalden@mit.edu: https://hg.mozilla.org/integration/autoland/rev/396f46672028 Move PCCount profiling functions out of jsfriendapi.h to a standalone header. r=jandem
|
|
||
Comment 31•3 years ago
|
||
| bugherder | ||
|
|
||
Comment 32•2 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:sdetar, maybe it's time to close this bug?
|
||
Comment 33•2 years ago
|
||
We will still leave this open for now.
|
|
||
Updated•2 years ago
|
|
|
||
Comment 34•2 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:sdetar, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.
|
|
||
Updated•2 years ago
|
|
|
||
Comment 35•2 years ago
|
||
The bug assignee is inactive on Bugzilla, so the assignee is being reset.
|
|
||
Comment 36•1 year ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:sdetar, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.
|
|
||
Updated•1 year ago
|
Description
•