Closed Bug 166346 Opened 22 years ago Closed 21 years ago

set title attribute to bug summary for image maps in bug dependency graphs

Categories

(Bugzilla :: Reporting/Charting, enhancement)

2.16
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: james, Assigned: jouni)

References

Details

Attachments

(1 file, 5 obsolete files)

When webdotbase is set to a local executable, bugzilla will greate a client side
image map for the dependency graph.  It would be nice if bugzilla output title
attributes for these image maps so that the bug summaries are visible on mouse over.

This would give a nice compromise between not showing summaries (which gives a
decent size dependency graph, but not much info), and showing the summaries
(which makes the graph a lot bigger).
I am assigning all the bugs I am not working on in the immediate future to
nobody@bugzilla.org. This means:

- I will be able to search for bugs assigned to me as a list of bugs I'm going
to fix (which is as it should be), and
- people won't falsely assume I might be about to fix a bug when I'm not.

Gerv
Assignee: gerv → nobody
The attached patch adds title attributes to the dependency graph, so I can
hover the mouse cursor over a node to see its summary and status.  This gives
all the information of the "show summaries" mode, without using up lots of
space (the show summaries mode creates very wide graphs ...).
Attached patch same patch against cvs tip (obsolete) — Splinter Review
I attempted to update this to the cvs tip.  I can't get it to work though.  I
have other things I need to work on, if someone can mess with this and figure
out why it isn't working, go for it. :)
Attachment #111029 - Attachment is obsolete: true
This has been frequently requested on our installation, so I'm going to
implement this soon -> grabbing. 
Assignee: nobody → jouni
Attached patch Jouni-v1 (obsolete) — Splinter Review
Thanks to the original patch author for some ideas. I rewrote it, but the
structure is roughly the same as before.
Attachment #111030 - Attachment is obsolete: true
With the title attributes for areas, I wonder if the "show summaries" option is
really that useful.  In my experience it just results in very wide images which
are a lot less useful in visualising the dependencies.  I am not sure what
Bugzilla's policy is on removing possibly useless features though ...
Comment on attachment 114080 [details] [diff] [review]
Jouni-v1

Dave, can you take a look at this? It seems you've tried the previous patch as
well.
Attachment #114080 - Flags: review?(justdave)
>With the title attributes for areas, I wonder if the "show summaries" option is
>really that useful. 

They really are. Tooltips don't show up very well in printed graphs :)
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.18
Comment on attachment 114080 [details] [diff] [review]
Jouni-v1

You can't put the summaries in HTML tags without escaping them.
Attachment #114080 - Flags: review?(justdave) → review-
As I mentioned in bug 192661 comment 0, I knew that (but I had this done before 
I realized the hole existed). I forgot to note that down here, as it was clear 
that this wasn't going to be checked in before the security fix anyway.

So, it seems that the lack of two value_quote calls prevented reviewing the 
patch otherwise. Fine, I'll update this when 192661 has landed. Let's see some 
more thereafter.
Attached patch Jouni-v2 (obsolete) — Splinter Review
All right. This doesn't stumble over the security issues, and I did some
cleanup as well.
Attachment #114080 - Attachment is obsolete: true
Attachment #136490 - Flags: review?(justdave)
Comment on attachment 136490 [details] [diff] [review]
Jouni-v2

This looks quite good. I had a hard time understanding how this file actually
works, but that's not your fault.

So I'll give a *conditional* r=. The condition is that you add some helpful
comments to this file that explain what on earth is happening there (be sure to
include the fact that there are three different files relevant, and the reason
why we need a global bugtitles) -- the fact that  this file has one lonely (and
irrelevant) comment is appalling.

I'm sorry to take advantage of you, but it's the natural consequence of you
being the only person alive that actually understands what this page does
<wink>

Just add the comments and carry over my r= when you seek approval. Thanks!
Attachment #136490 - Flags: review?(justdave) → review+
Attached patch Jouni-v2, with added comments (obsolete) — Splinter Review
Ok, the same as previously but with some übercool comments added.
Comment on attachment 136668 [details] [diff] [review]
Jouni-v2, with added comments

Witty comments get you bonus credits, r=kiko
Attachment #136668 - Flags: review+
Flags: approval?
I'll attach this final (for now ;-)) patch so that somebody else can check this
in in case of a panic and me MIA.
Attachment #136490 - Attachment is obsolete: true
Attachment #136668 - Attachment is obsolete: true
Comment on attachment 136670 [details] [diff] [review]
v2b, added comments and fixed nits

it works and I like it :)
Attachment #136670 - Flags: review+
Flags: approval? → approval+
Checking in showdependencygraph.cgi;
/cvsroot/mozilla/webtools/bugzilla/showdependencygraph.cgi,v  <-- 
showdependencygraph.cgi
new revision: 1.32; previous revision: 1.31
done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
*** Bug 233176 has been marked as a duplicate of this bug. ***
Blocks: 357701
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: