Closed Bug 1663506 Opened 4 years ago Closed 2 years ago

Intermittent browser/base/content/test/outOfProcess/browser_controller.js | step 0 selected undo - Got false, expected true

Categories

(Core :: DOM: Editor, defect, P5)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1781353

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell unknown])

Attachments

(1 file)

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=315036450&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/dHypJ6wcSD2VhcGkB4uT9Q/runs/0/artifacts/public/logs/live_backing.log


[task 2020-09-07T19:33:39.443Z] 19:33:39 INFO - TEST-PASS | browser/base/content/test/outOfProcess/browser_controller.js | input focused - {} == {} -
[task 2020-09-07T19:33:39.444Z] 19:33:39 INFO - Buffered messages finished
[task 2020-09-07T19:33:39.444Z] 19:33:39 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/outOfProcess/browser_controller.js | step 0 selected undo - Got false, expected true
[task 2020-09-07T19:33:39.444Z] 19:33:39 INFO - Stack trace:
[task 2020-09-07T19:33:39.444Z] 19:33:39 INFO - chrome://mochikit/content/browser-test.js:test_is:1332
[task 2020-09-07T19:33:39.444Z] 19:33:39 INFO - chrome://mochitests/content/browser/browser/base/content/test/outOfProcess/browser_controller.js:checkCommandState:2
[task 2020-09-07T19:33:39.444Z] 19:33:39 INFO - chrome://mochitests/content/browser/browser/base/content/test/outOfProcess/browser_controller.js:test_controllers_subframes:108
[task 2020-09-07T19:33:39.444Z] 19:33:39 INFO - TEST-PASS | browser/base/content/test/outOfProcess/browser_controller.js | step 0 selected copy -
[task 2020-09-07T19:33:39.444Z] 19:33:39 INFO - TEST-PASS | browser/base/content/test/outOfProcess/browser_controller.js | step 0 selected delete -

Could this be caused by bug 1658702?

Flags: needinfo?(masayuki)

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #1)

Could this be caused by bug 1658702?

I don't think so, but might be. Bug 1658702 touches almost only path running when the editor is an HTML editor, but touches EditorBase and TextEditor too.

And the test failure is here:
https://searchfox.org/mozilla-central/rev/8a0745cd346f0cfb89ae71690babbf7bff706113/browser/base/content/test/outOfProcess/browser_controller.js#108

i.e., the test failure is whether "undo" is enabled or disabled, but I didn't touch undo/redo transaction in above changes.

It seems that Accel + A causes the <input> element blurred. Could be a regression of focus management? Henri, do you know some bugs to change around there?

Flags: needinfo?(masayuki) → needinfo?(hsivonen)

My recent non-Fission-specific change was adding the ability to move focus into the initial about:blank of an iframe that hasn't yet loaded whatever it's really supposed to start loading.

Flags: needinfo?(hsivonen)

Thank you, Henri.

This is older bug than bug 1664411's fix, but it seems that the fix of bug 1664411 might increase the frequency. Emilio, do you have any ideas?

Flags: needinfo?(emilio)

I have zero idea how bug 1664411 could've possibly changed behavior in any particular way. Are you sure you meant that bug?

Flags: needinfo?(emilio)

(In reply to Emilio Cobos Álvarez (:emilio) from comment #6)

I have zero idea how bug 1664411 could've possibly changed behavior in any particular way. Are you sure you meant that bug?

Honestly, I have no idea, but the graph indicates that the failure becomes increased starting from the day of landing the patches of bug 1664411. If it touches something cause of this bug, it gives us a hint of the cause. Therefore, I just ask you whether you have some ideas or not.

It may be that due to my changes that test ran more often that day, that's the only thing that comes to mind.

Is there any chance to retrigger this to see when it became so frequent?

Flags: needinfo?(sheriffs)

Awesome, that's super-helpful, thanks Alexandru!

Flags: needinfo?(jstutte)
Whiteboard: [stockwell needswork:owner]
Assignee: nobody → apavel
Status: NEW → ASSIGNED
Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/567ec51fb088
disable browser_controller.js on 64bits platforms r=intermittent-reviewers,jmaher DONTBUILD
Keywords: leave-open
Whiteboard: [stockwell needswork:owner] → [stockwell needswork:owner][stockwell disabled]
Assignee: apavel → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(jstutte)
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: