Intermittent browser/base/content/test/outOfProcess/browser_controller.js | step 0 selected undo - Got false, expected true
Categories
(Core :: DOM: Editor, defect, P5)
Tracking
()
People
(Reporter: intermittent-bug-filer, Unassigned)
References
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell unknown])
Attachments
(1 file)
Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=315036450&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/dHypJ6wcSD2VhcGkB4uT9Q/runs/0/artifacts/public/logs/live_backing.log
[task 2020-09-07T19:33:39.443Z] 19:33:39 INFO - TEST-PASS | browser/base/content/test/outOfProcess/browser_controller.js | input focused - {} == {} -
[task 2020-09-07T19:33:39.444Z] 19:33:39 INFO - Buffered messages finished
[task 2020-09-07T19:33:39.444Z] 19:33:39 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/outOfProcess/browser_controller.js | step 0 selected undo - Got false, expected true
[task 2020-09-07T19:33:39.444Z] 19:33:39 INFO - Stack trace:
[task 2020-09-07T19:33:39.444Z] 19:33:39 INFO - chrome://mochikit/content/browser-test.js:test_is:1332
[task 2020-09-07T19:33:39.444Z] 19:33:39 INFO - chrome://mochitests/content/browser/browser/base/content/test/outOfProcess/browser_controller.js:checkCommandState:2
[task 2020-09-07T19:33:39.444Z] 19:33:39 INFO - chrome://mochitests/content/browser/browser/base/content/test/outOfProcess/browser_controller.js:test_controllers_subframes:108
[task 2020-09-07T19:33:39.444Z] 19:33:39 INFO - TEST-PASS | browser/base/content/test/outOfProcess/browser_controller.js | step 0 selected copy -
[task 2020-09-07T19:33:39.444Z] 19:33:39 INFO - TEST-PASS | browser/base/content/test/outOfProcess/browser_controller.js | step 0 selected delete -
Comment 2•4 years ago
|
||
(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #1)
Could this be caused by bug 1658702?
I don't think so, but might be. Bug 1658702 touches almost only path running when the editor is an HTML editor, but touches EditorBase
and TextEditor
too.
- https://hg.mozilla.org/mozilla-central/diff/c1fa84508a52f140ca9cd52710c8f53391eaa996/editor/libeditor/EditorBase.cpp
- https://hg.mozilla.org/mozilla-central/diff/1a0b21debe92db3bf4db1d04c41da9b3aa8625f1/editor/libeditor/EditorBase.cpp
- https://hg.mozilla.org/mozilla-central/diff/1a0b21debe92db3bf4db1d04c41da9b3aa8625f1/editor/libeditor/TextEditSubActionHandler.cpp
- https://hg.mozilla.org/mozilla-central/diff/9714d40b233b8bf3b2ccf0b35fba55fa80a712b3/editor/libeditor/EditorBase.cpp
And the test failure is here:
https://searchfox.org/mozilla-central/rev/8a0745cd346f0cfb89ae71690babbf7bff706113/browser/base/content/test/outOfProcess/browser_controller.js#108
i.e., the test failure is whether "undo" is enabled or disabled, but I didn't touch undo/redo transaction in above changes.
It seems that Accel + A
causes the <input>
element blurred. Could be a regression of focus management? Henri, do you know some bugs to change around there?
Comment 3•4 years ago
|
||
My recent non-Fission-specific change was adding the ability to move focus into the initial about:blank
of an iframe that hasn't yet loaded whatever it's really supposed to start loading.
Comment 4•4 years ago
|
||
Thank you, Henri.
This is older bug than bug 1664411's fix, but it seems that the fix of bug 1664411 might increase the frequency. Emilio, do you have any ideas?
Comment hidden (Intermittent Failures Robot) |
Comment 6•4 years ago
|
||
I have zero idea how bug 1664411 could've possibly changed behavior in any particular way. Are you sure you meant that bug?
Comment 7•4 years ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #6)
I have zero idea how bug 1664411 could've possibly changed behavior in any particular way. Are you sure you meant that bug?
Honestly, I have no idea, but the graph indicates that the failure becomes increased starting from the day of landing the patches of bug 1664411. If it touches something cause of this bug, it gives us a hint of the cause. Therefore, I just ask you whether you have some ideas or not.
Comment 8•4 years ago
|
||
It may be that due to my changes that test ran more often that day, that's the only thing that comes to mind.
Is there any chance to retrigger this to see when it became so frequent?
Comment 9•4 years ago
|
||
Emilio, I triggered a couple of retriggers on the day the bug first appeared and on it's most recent appearance.
As far as I can tell your theory is correct, since the failure rate between both retriggers is the same:
Please correct me if I'm wrong here or you wanted to test something else.
Comment 10•4 years ago
|
||
Awesome, that's super-helpful, thanks Alexandru!
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 28•3 years ago
|
||
There have been 40 total failures in the last 7 days: https://treeherder.mozilla.org/intermittent-failures/bugdetails?startday=2020-12-29&endday=2021-01-05&tree=trunk&bug=1663506
Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=325733717&repo=mozilla-central&lineNumber=2280
Jens, could you assign this to someone?
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 31•3 years ago
|
||
Updated•3 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment 33•3 years ago
|
||
Pushed by rmaries@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/567ec51fb088 disable browser_controller.js on 64bits platforms r=intermittent-reviewers,jmaher DONTBUILD
Updated•3 years ago
|
Comment 34•3 years ago
|
||
bugherder |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•3 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•3 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•2 years ago
|
Updated•2 years ago
|
Description
•