Closed Bug 1663509 Opened 4 years ago Closed 2 years ago

Intermittent dom/animation/test/mozilla/test_restyles.html | <random failure>

Categories

(Core :: DOM: Animation, defect)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1784931

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell disabled][stockwell needswork:owner])

Attachments

(3 files)

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=315034656&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/acww98pFSBGp7R729c1PsA/runs/0/artifacts/public/logs/live_backing.log


[task 2020-09-07T19:30:42.290Z] 19:30:42 INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | Animations that was in visibility hidden parent should not throttle restyling any more
[task 2020-09-07T19:30:42.290Z] 19:30:42 INFO - Buffered messages finished
[task 2020-09-07T19:30:42.290Z] 19:30:42 INFO - TEST-UNEXPECTED-FAIL | dom/animation/test/mozilla/test_restyles.html | Animations that the parent element became visible should throttle restyling again - got 5, expected +0
[task 2020-09-07T19:30:42.290Z] 19:30:42 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:500:14
[task 2020-09-07T19:30:42.291Z] 19:30:42 INFO - restyling_animations_in_visibility_changed_parent@dom/animation/test/mozilla/file_restyles.html:681:7
[task 2020-09-07T19:30:42.291Z] 19:30:42 INFO - add_task | Leaving test restyling_animations_in_visibility_changed_parent
[task 2020-09-07T19:30:42.291Z] 19:30:42 INFO - add_task | Entering test restyling_animations_on_visibility_hidden_element_with_visibility_changed_children
[task 2020-09-07T19:30:42.291Z] 19:30:42 INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | Animations on visibility hidden element having no visible children should never cause restyles

Many failures have been filed against this test this week. Please investigate what happened and what needs to be done. For the time being, code sheriffs will stop creating new bugs for this test and classify the failures against this bug.

Severity: normal → --
Flags: needinfo?(boris.chiou)
Priority: P5 → --
Summary: Intermittent dom/animation/test/mozilla/test_restyles.html | Animations that the parent element became visible should throttle restyling again - got 5, expected +0 → Intermittent dom/animation/test/mozilla/test_restyles.html | <random failure>
Flags: needinfo?(boris.chiou)
Flags: needinfo?(boris.chiou)

Looks like all happened on Windows.

This is quite unfortunate. Random failures in test_restyles.html means unexpected style flushes happen during running the test. Given that all failures happened on Windows 7, my gut feeling tells me that font loading on the platform or Windows (7 specific?) ua style sheets are suspicious. That said I am totally unsure, it's quite hard to tell without debugging.

I found there is a failure on Window 10, https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=81d47e62000723a24bb20f1abdda51cfc62c553f&selectedTaskRun=DSYJKNWETriHVq70plaqfA.0 , so it's not specific for Windows 7, it's specific for Windows?

Flags: needinfo?(boris.chiou)

(In reply to Hiroyuki Ikezoe (:hiro) from comment #29)

I found there is a failure on Window 10, https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=81d47e62000723a24bb20f1abdda51cfc62c553f&selectedTaskRun=DSYJKNWETriHVq70plaqfA.0 , so it's not specific for Windows 7, it's specific for Windows?

Have you seen any failure on your local build on windows?

There are 35 total failures in the last 7 days on

  • windows10 asan, opt and debug
  • windows7-32 opt and debug
  • windows7-32-shippable opt

Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=331944029&repo=mozilla-beta&lineNumber=2239

[task 2021-03-03T20:36:10.378Z] 20:36:10 INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | Animation on position:absolute element in collapsed iframe should be throttled
[task 2021-03-03T20:36:10.378Z] 20:36:10 INFO - add_task | Leaving test throttling_position_absolute_animations_in_collapsed_iframe
[task 2021-03-03T20:36:10.378Z] 20:36:10 INFO - add_task | Entering test position_absolute_animations_in_collapsed_element
[task 2021-03-03T20:36:10.378Z] 20:36:10 INFO - Buffered messages logged at 20:36:10
[task 2021-03-03T20:36:10.379Z] 20:36:10 INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | Animation on position:absolute element in collapsed element should not be throttled
[task 2021-03-03T20:36:10.379Z] 20:36:10 INFO - add_task | Leaving test position_absolute_animations_in_collapsed_element
[task 2021-03-03T20:36:10.379Z] 20:36:10 INFO - add_task | Entering test throttling_position_absolute_animations_in_collapsed_element
[task 2021-03-03T20:36:10.379Z] 20:36:10 INFO - TEST-FAIL | dom/animation/test/mozilla/test_restyles.html | Animation on collapsed position:absolute element in collapsed element should be throttled - got 5, expected +0
[task 2021-03-03T20:36:10.379Z] 20:36:10 INFO - add_task | Leaving test throttling_position_absolute_animations_in_collapsed_element
[task 2021-03-03T20:36:10.379Z] 20:36:10 INFO - add_task | Entering test no_restyling_for_compositor_animation_on_unrelated_style_change
[task 2021-03-03T20:36:10.379Z] 20:36:10 INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | The opacity animation is running on the compositor
[task 2021-03-03T20:36:10.379Z] 20:36:10 INFO - Buffered messages finished
[task 2021-03-03T20:36:10.380Z] 20:36:10 INFO - TEST-UNEXPECTED-FAIL | dom/animation/test/mozilla/test_restyles.html | The opacity animation keeps running on the compositor when color style is changed - got 1, expected +0
[task 2021-03-03T20:36:10.380Z] 20:36:10 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:500:14
[task 2021-03-03T20:36:10.380Z] 20:36:10 INFO - no_restyling_for_compositor_animation_on_unrelated_style_change@dom/animation/test/mozilla/file_restyles.html:1577:9
[task 2021-03-03T20:36:10.380Z] 20:36:10 INFO - add_task | Leaving test no_restyling_for_compositor_animation_on_unrelated_style_change
[task 2021-03-03T20:36:10.380Z] 20:36:10 INFO - add_task | Entering test no_overflow_transform_animations_in_scrollable_element
[task 2021-03-03T20:36:10.380Z] 20:36:10 INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | undefined assertion name
[task 2021-03-03T20:36:10.675Z] 20:36:10 INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | No-overflow transform animations running on the compositor should never update style on the main thread
[task 2021-03-03T20:36:10.694Z] 20:36:10 INFO - add_task | Leaving test no_overflow_transform_animations_in_scrollable_element
[task 2021-03-03T20:36:10.694Z] 20:36:10 INFO - add_task | Entering test no_flush_on_getAnimations
[task 2021-03-03T20:36:10.729Z] 20:36:10 INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | undefined assertion name
[task 2021-03-03T20:36:10.729Z] 20:36:10 INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | There should be one animation
[task 2021-03-03T20:36:10.729Z] 20:36:10 INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | Element.getAnimations() should not flush throttled animation style
[task 2021-03-03T20:36:10.749Z] 20:36:10 INFO - add_task | Leaving test no_flush_on_getAnimations
[task 2021-03-03T20:36:10.749Z] 20:36:10 INFO - add_task | Entering test restyling_for_throttled_animation_on_getAnimations
[task 2021-03-03T20:36:10.776Z] 20:36:10 INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | undefined assertion name
[task 2021-03-03T20:36:10.776Z] 20:36:10 INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | There should be no animation
[task 2021-03-03T20:36:10.776Z] 20:36:10 INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | Element.getAnimations() should flush throttled animation style so that the throttled animation is discarded
[task 2021-03-03T20:36:10.796Z] 20:36:10 INFO - add_task | Leaving test restyling_for_throttled_animation_on_getAnimations

Boris can you assign someone to take a look?

Flags: needinfo?(boris.chiou)
Whiteboard: [stockwell needswork:owner]
Assignee: nobody → abutkovits
Status: NEW → ASSIGNED
Assignee: abutkovits → nobody
Status: ASSIGNED → NEW
Keywords: leave-open

Hi Hiro, any chance to take a look at test_restyle.html on Windows? Looks like the orange factor is a little bit high on windows recently.

Flags: needinfo?(boris.chiou) → needinfo?(hikezoe.birchill)

Looks like all failures are non WebRender. If it's true, I am not too worried the failure since we will enable WebRender on all platforms by default.

Sherif, if we need to disable this test, please make sure that failures have been happening on non WebRender and skip this test only without WebRender. Thanks!

Flags: needinfo?(hikezoe.birchill)
Pushed by abutkovits@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/266a6e68fe63
disable test_restyles.html for frequent failures. r=intermittent-reviewers,jmaher DONTBUILD
Whiteboard: [stockwell needswork:owner] → [stockwell disabled][stockwell needswork:owner]

There are 32 total failures in the last 7 days on

[task 2021-09-02T11:37:18.830Z] 11:37:18     INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | Transform animation with partial pre-rendered should never cause restyles 
[task 2021-09-02T11:37:18.830Z] 11:37:18     INFO - add_task | Leaving test partial_prerendered_transform_animations
[task 2021-09-02T11:37:18.830Z] 11:37:18     INFO - add_task | Entering test restyling_on_create_animation
[task 2021-09-02T11:37:18.831Z] 11:37:18     INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | Creating animations should not flush styles 
[task 2021-09-02T11:37:18.831Z] 11:37:18     INFO - add_task | Leaving test restyling_on_create_animation
[task 2021-09-02T11:37:18.832Z] 11:37:18     INFO - add_task | Entering test out_of_view_background_position
[task 2021-09-02T11:37:18.832Z] 11:37:18     INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | background-position animations can be throttled 
[task 2021-09-02T11:37:18.832Z] 11:37:18     INFO - add_task | Leaving test out_of_view_background_position
[task 2021-09-02T11:37:18.833Z] 11:37:18     INFO - add_task | Entering test no_restyling_animations_in_opacity_zero_element
[task 2021-09-02T11:37:18.833Z] 11:37:18     INFO - Buffered messages logged at 11:37:18
[task 2021-09-02T11:37:18.833Z] 11:37:18     INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | Animations running on the main thread in opacity: 0 element should never cause restyles 
[task 2021-09-02T11:37:18.834Z] 11:37:18     INFO - add_task | Leaving test no_restyling_animations_in_opacity_zero_element
[task 2021-09-02T11:37:18.834Z] 11:37:18     INFO - add_task | Entering test no_restyling_compositor_animations_in_opacity_zero_descendant
[task 2021-09-02T11:37:18.834Z] 11:37:18     INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | undefined assertion name 
[task 2021-09-02T11:37:18.835Z] 11:37:18     INFO - Buffered messages finished
[task 2021-09-02T11:37:18.835Z] 11:37:18     INFO - TEST-UNEXPECTED-FAIL | dom/animation/test/mozilla/test_restyles.html | Animations running on the compositor in opacity zero descendant element should never cause restyles - got 1, expected +0
[task 2021-09-02T11:37:18.836Z] 11:37:18     INFO -     SimpleTest.is@SimpleTest/SimpleTest.js:500:14
[task 2021-09-02T11:37:18.836Z] 11:37:18     INFO -     no_restyling_compositor_animations_in_opacity_zero_descendant@dom/animation/test/mozilla/file_restyles.html:2065:7
[task 2021-09-02T11:37:18.836Z] 11:37:18     INFO - add_task | Leaving test no_restyling_compositor_animations_in_opacity_zero_descendant
[task 2021-09-02T11:37:18.836Z] 11:37:18     INFO - add_task | Entering test no_restyling_compositor_animations_in_opacity_zero_descendant_abspos
[task 2021-09-02T11:37:18.837Z] 11:37:18     INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | undefined assertion name 
[task 2021-09-02T11:37:18.856Z] 11:37:18     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-09-02T11:37:18.857Z] 11:37:18     INFO - TEST-UNEXPECTED-FAIL | dom/animation/test/mozilla/test_restyles.html | Animations running on the compositor in opacity zero abspos descendant element should never cause restyles - got 1, expected +0
[task 2021-09-02T11:37:18.857Z] 11:37:18     INFO -     SimpleTest.is@SimpleTest/SimpleTest.js:500:14
[task 2021-09-02T11:37:18.857Z] 11:37:18     INFO -     no_restyling_compositor_animations_in_opacity_zero_descendant_abspos@dom/animation/test/mozilla/file_restyles.html:2082:7
[task 2021-09-02T11:37:18.898Z] 11:37:18     INFO - add_task | Leaving test no_restyling_compositor_animations_in_opacity_zero_descendant_abspos
[task 2021-09-02T11:37:18.899Z] 11:37:18     INFO - add_task | Entering test restyling_main_thread_animations_in_opacity_zero_descendant_after_root_opacity_animation
[task 2021-09-02T11:37:19.274Z] 11:37:19     INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | Animations running on the compositor in opacity zero descendant element should never cause restyles after root animation has finished 
[task 2021-09-02T11:37:19.315Z] 11:37:19     INFO - add_task | Leaving test restyling_main_thread_animations_in_opacity_zero_descendant_after_root_opacity_animation
[task 2021-09-02T11:37:19.316Z] 11:37:19     INFO - add_task | Entering test restyling_main_thread_animations_in_opacity_zero_descendant_during_root_opacity_animation
[task 2021-09-02T11:37:19.607Z] 11:37:19     INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | Animations in opacity zero descendant element should not be throttled if root is animating opacity 
[task 2021-09-02T11:37:19.649Z] 11:37:19     INFO - add_task | Leaving test restyling_main_thread_animations_in_opacity_zero_descendant_during_root_opacity_animation
[task 2021-09-02T11:37:19.649Z] 11:37:19     INFO - add_task | Entering test transparent_background_color_animations
[task 2021-09-02T11:37:19.731Z] 11:37:19     INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | undefined assertion name 
[task 2021-09-02T11:37:19.940Z] 11:37:19     INFO - TEST-PASS | dom/animation/test/mozilla/test_restyles.html | transparent background-color animation should not update styles on the main thread 
[task 2021-09-02T11:37:19.982Z] 11:37:19     INFO - add_task | Leaving test transparent_background_color_animations
[task 2021-09-02T11:37:19.984Z] 11:37:19     INFO - GECKO(1307) | MEMORY STAT | vsize 6607MB | residentFast 96MB | heapAllocated 10MB
[task 2021-09-02T11:37:20.000Z] 11:37:20     INFO - TEST-OK | dom/animation/test/mozilla/test_restyles.html | took 33540ms

Hiro are you by any chance working on this?

Flags: needinfo?(hikezoe.birchill)

There's no failure on Linux...

Assignee: nobody → hikezoe.birchill
Status: NEW → ASSIGNED
Flags: needinfo?(hikezoe.birchill)

Markus told me a place in our code to know hardware vsync rate, and Joel Maher told me that Macs on our CI use HDMI dongles.

It turns out some of the macs are 24Hz vsync. In such macs some of tests in test_restyles.html don't work as expected since we do unthrottle throttled animations periodically if the animation's style changes might change overflow regions. The period is 200ms.

In test_resytles.html we do observe animation styling count during 5 frames, if the vsync rate is 24Hz, it takes approximately 41.6ms in each frame, thus it takes over 200ms on 5 frames. That means, during the 5 frames we unthrottle once, that's the reason why some tests fail on mac.

I am going to skip all test in file_restyles.html on such machines since in these days 24Hz vsync isn't commonly used I believe.

Note that failures on Windows seem to be caused by different reasons. I will keep this bug open for the Windows failures.

Pushed by hikezoe.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/26290aae98cf
Skip test_restyles.html if the target machine's vsync rate is too slow to run the test. r=boris

Unassigning myself for now. I haven't looked into the failure on Windows, if we need an owner here, please NI to me. Thanks!

Status: ASSIGNED → NEW
Assignee: hikezoe.birchill → nobody

There are 23 total failures in the last 7 days on

[task 2021-12-21T05:04:58.225Z] 05:04:58     INFO -  TEST-START | dom/animation/test/mozilla/test_restyles.html
[task 2021-12-21T05:04:58.226Z] 05:04:58     INFO -  Buffered messages logged at 05:04:49
[task 2021-12-21T05:04:58.226Z] 05:04:58     INFO -  add_task | Entering test
[task 2021-12-21T05:04:58.226Z] 05:04:58     INFO -  add_task | Leaving test
[task 2021-12-21T05:04:58.226Z] 05:04:58     INFO -  add_task | Entering test restyling_for_main_thread_animations
[task 2021-12-21T05:04:58.227Z] 05:04:58     INFO -  TEST-PASS | dom/animation/test/mozilla/test_restyles.html | undefined assertion name
[task 2021-12-21T05:04:58.227Z] 05:04:58     INFO -  Buffered messages logged at 05:04:50
[task 2021-12-21T05:04:58.227Z] 05:04:58     INFO -  TEST-PASS | dom/animation/test/mozilla/test_restyles.html | CSS animations running on the main-thread should update style on the main thread
[task 2021-12-21T05:04:58.227Z] 05:04:58     INFO -  add_task | Leaving test restyling_for_main_thread_animations
[task 2021-12-21T05:04:58.227Z] 05:04:58     INFO -  add_task | Entering test restyling_for_main_thread_animations_progress_bar_pseudo
[task 2021-12-21T05:04:58.227Z] 05:04:58     INFO -  Buffered messages finished
[task 2021-12-21T05:04:58.228Z] 05:04:58  WARNING -  TEST-UNEXPECTED-FAIL | dom/animation/test/mozilla/test_restyles.html | CSS animations running on the main-thread should update style on the main thread on ::-moz-progress-bar - got 4, expected 5
[task 2021-12-21T05:04:58.228Z] 05:04:58     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:500:14
[task 2021-12-21T05:04:58.228Z] 05:04:58     INFO -      restyling_for_main_thread_animations_progress_bar_pseudo@dom/animation/test/mozilla/file_restyles.html:174:7
[task 2021-12-21T05:04:58.228Z] 05:04:58     INFO -  TEST-PASS | dom/animation/test/mozilla/test_restyles.html | Animation is correctly removed
[task 2021-12-21T05:04:58.228Z] 05:04:58     INFO -  add_task | Leaving test restyling_for_main_thread_animations_progress_bar_pseudo
[task 2021-12-21T05:04:58.229Z] 05:04:58     INFO -  add_task | Entering test no_restyling_for_compositor_animations
[task 2021-12-21T05:04:58.229Z] 05:04:58     INFO -  TEST-PASS | dom/animation/test/mozilla/test_restyles.html | undefined assertion name
[task 2021-12-21T05:04:58.229Z] 05:04:58     INFO -  TEST-PASS | dom/animation/test/mozilla/test_restyles.html | CSS animations running on the compositor should not update style on the main thread
[task 2021-12-21T05:04:58.229Z] 05:04:58     INFO -  add_task | Leaving test no_restyling_for_compositor_animations
[task 2021-12-21T05:04:58.229Z] 05:04:58     INFO -  add_task | Entering test no_restyling_for_compositor_transitions
[task 2021-12-21T05:04:58.229Z] 05:04:58     INFO -  TEST-PASS | dom/animation/test/mozilla/test_restyles.html | undefined assertion name
[task 2021-12-21T05:04:58.230Z] 05:04:58     INFO -  TEST-PASS | dom/animation/test/mozilla/test_restyles.html | CSS transitions running on the compositor should not update style on the main thread

Boris, please take a look when you have time. Thank you.

Flags: needinfo?(boris.chiou)
Whiteboard: [stockwell disabled][stockwell unknown] → [stockwell disabled][stockwell needswork:owner]

Boris is on PTO, I will spend a day or so. A quick note that all failures both on Linux and Android are -moz-progress bar one. I am not going to scope the one.

Flags: needinfo?(hikezoe.birchill)

I am unable to reproduce this failure on my Windows laptop so far. The revision I am using is a6af5cff5adf1e7aebb5072f917bef5b12ade24d.

Though I wasn't able to reproduce the failure locally, a speculative change seemed to fix the failure;

https://treeherder.mozilla.org/jobs?repo=try&revision=eba09e3d3a79d9873c34479fa84705e81f6ba034

Assignee: nobody → hikezoe.birchill
Status: NEW → ASSIGNED
Flags: needinfo?(hikezoe.birchill)
Flags: needinfo?(boris.chiou)
Attachment #9257573 - Attachment description: Bug 1663509 - Use z-index animation instead of transform animation to avoid unthrottling every 200ms [1]. r?boris → Bug 1663509 - Use background-color animation instead of transform animation to avoid unthrottling every 200ms [1]. r?boris
Pushed by hikezoe.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/788de1f20d3e
Use background-color animation instead of transform animation to avoid unthrottling every 200ms [1]. r=boris

Looks like the failure on Windows has been fixed. There's still a failure case I mentioned in comment 103.

Assignee: hikezoe.birchill → nobody
Status: ASSIGNED → NEW

There have been 39 total failures in the last 7 days, recent failure log.
Affected platforms are:

  • windows10-32-2004-qr
  • macosx1015-64-qr
  • linux1804-64-tsan-qr
  • linux1804-64-qr
  • android-em-7-0-x86_64-qr
Flags: needinfo?(boris.chiou)
Whiteboard: [stockwell disabled][stockwell unknown] → [stockwell disabled][stockwell needswork:owner]

There have been 69 total failures in the last 7 days, recent failure log.
Affected platforms are:

  • android-em-7-0-x86_64-qr
  • linux1804-64-asan-qr
  • linux1804-64-qr
  • linux1804-64-tsan-qr
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → DUPLICATE
Flags: needinfo?(boris.chiou)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: