we run some tests with classic (layout) scrollbars and use the minimum scale size for the scroll frame
Categories
(Core :: Panning and Zooming, defect, P3)
Tracking
()
People
(Reporter: tnikkel, Unassigned)
References
Details
Attachments
(1 file)
1.71 KB,
patch
|
Details | Diff | Splinter Review |
Using the minimum scale size with layout/classic scrollbars is not supported and buggy. Making it work is somewhat hard and not very important since it's minscale is more important for mobile where there are no layout/classic scrollbars.
This bug is to fix this so it doesn't happen in our tests. Ways to fix
- set ui.useOverlayScrollbars pref in any test where this happens
- disable the min scale code if we don't have overlay scrollbars
Here is a try push where I assert anytime we use the min scale size and the size is different from what we would have done and we have layout/classic scrollbars.
There are several failures that are unrelated in that push, so just ignore anything that isn't a fatal assert.
Reporter | ||
Comment 1•4 years ago
|
||
Here's a patch I use to assert.
Comment 2•4 years ago
|
||
Do you intend to land this patch (or some variant)? It would be good to do so to catch further tests getting added that trigger this condition.
Reporter | ||
Comment 3•4 years ago
•
|
||
We need to fix the tests first (or our code to ignore min scale with layout scrollbars). I only fixed the reftests. There are some other failures that I haven't looked into at all (because the tests don't fail with my desktop zooming patches).
Updated•4 years ago
|
Description
•