Closed
Bug 1663618
Opened 5 years ago
Closed 5 years ago
Lots of time diffing custom properties on youtube.
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
82 Branch
| Tracking | Status | |
|---|---|---|
| firefox82 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
Details
Attachments
(1 file)
When entering or leaving fullscreen in youtube, we spend most of the restyle time diffing custom properties.
Turns out this is slower than it needs to be.
|
Assignee | |
Comment 1•5 years ago
|
||
When entering or leaving fullscreen in youtube, we spend most of the
restyle time diffing custom properties, under IndexMap::eq.
Turns out that IndexMap equality is not order-aware, and thus you
actually need to make a hashmap lookup for each entry in the map, which
is unnecessarily inefficient.
Instead, just compare the iterators.
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d46a20917d66
Speed up custom property diffing. r=boris
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox82:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•