1663631 - The Media Controls stop working after skipping to the next song on Soundcloud

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Rares Doghi, Desktop QA]

Attachment: 2020-09-08_14h28_16.mp4

[Affected platforms]:
Platforms: Windows 10, MAC OSX, Ubuntu 18.04

[Preconditions]:
Ensure both pref media.hardwaremediakeys.enabled and dom.media.mediasession.enabled are true

Steps :

1. Launch the Firefox browser and reach https://soundcloud.com/search?q=eminem
2. Hit play on the first video.
3. Use the Pause/Play Media Control Key in order to stop and start the song.
4. Hit the "Next" Media control Key.
5. Try to Pause/Play the next song using the media control key

Expected Results :
The user should be able to Pause/Play or Skip songs using the Media control Keys from the keyboard or from the Virtual Control interface.

Actual Results :
After skipping the first song that plays with sound the Virtual Control interface will disappear and the user will no longer be able to control the song using the Media Control keys from the keyboard.

Please note that the songs are displayed in a form of a playlist even though its the result of a search. (you can see the entire playlist on the button of the screen on the right where music controls are.)
Please also not that If the user plays the Next song manually using the mouse the song can be controlled from the media keys without any issues.

Comment 1

[Alastor Wu [:alwu]]

I can reproduce this issue.

Comment 2

[Jon Bauman [:jbauman:]]

Per https://support.mozilla.org/fr/kb/control-audio-or-video-playback-your-headset-or-keyboard and https://developers.soundcloud.com/blog/playback-on-web-at-soundcloud, I think the issue may be that media from web-audio cannot be controlled with media control keys, but I I'll defer to Alastor on this.

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1663631 - part1 : disconnect audible listener when we recreate a media sink or shutdown.

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1663631 - part2 : add a test.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53ac662ab8f9
part1 : disconnect audible listener when we recreate a media sink or shutdown. r=bryce
https://hg.mozilla.org/integration/autoland/rev/900440de905d
part2 : add a test. r=bryce

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/53ac662ab8f9
https://hg.mozilla.org/mozilla-central/rev/900440de905d

Comment 7

[Alastor Wu [:alwu]]

Comment on attachment 9176308 [details]
Bug 1663631 - part1 : disconnect audible listener when we recreate a media sink or shutdown.

Beta/Release Uplift Approval Request

• User impact if declined: Sometime users would be not able to control media via media keys on soundcloud after pressing next/previous track
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Follow comment0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It doesn't introduce new behavior change, the fix is about correcting media audible state in order to let Firefox detecting those audible media and being able to control them via media keys. Also, we have an automation test to cover this issue.
• String changes made/needed: No

Comment 8

[Rares Doghi, Desktop QA]

Hi, This issue is verified as fixed Windows 10, Mac Os and Ubuntu 18.04 using our latest nightly build 83.0a1 (2020-09-23).

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9176308 [details]
Bug 1663631 - part1 : disconnect audible listener when we recreate a media sink or shutdown.

approved for 82.0b3

Comment 10

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0e7352d16536
https://hg.mozilla.org/releases/mozilla-beta/rev/7db6f9261b21

Comment 11

[Rares Doghi, Desktop QA]

This issue is verified as fixed on Windows 10, Mac Os and Ubuntu 18.04 in beta 82.0b3 as well.