1663638 - CTRL+Z applies only to the latest action in tables

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P2)

Description

[matteo.sindona]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

1. login https://results.totallympics.com/
   Username: test
   Password: test

2. Go here: https://results.totallympics.com/forum.php?mod=post&action=edit&fid=100&tid=2908&pid=43939&page=1

3. You will find a table inside an editor. Add or remove some text from one of the cells

4. Click CTRL+Z on your keyboard to revert the last action. It works and the latest action is reverted, but:

5. try to add and/or remove text from two different cells (or even inside the same cell but in two different parts of it)

6. click on CTRL+Z two times. The second time you click on CTRL+Z nothing will happen. Only the latest action is reverted, but previous actions can not be undone.

7. This is happening ONLY inside the table. If you try to edit the "Test 1, Test 2, Test 3" part before the table, you will not face the problem and you can click CTRL+Z how many times you want, all the actions will reverted.

Comment 1

[matteo.sindona]

I made a video to show the difference in the behaviour of the CTRL+Z function with text inside the table (first part of the video) and outside the table (second part of the video): https://youtu.be/4EH9VS-fufE

Also, I am facing this problem since a couple of years, maybe three. But I am sure in some previous Mozilla version this was not happening. And if you need to know exactly from which version this problem started, I can try and find out by installing previous versions and try it.

Thank you!

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4153ce5276d5f44c77a928836453343d89a78b5d&tochange=efbc0c055fbc1511c181eadb728e135d9b7976eb

Comment 3

[Anne (:annevk)]

Thanks Alice, that's wonderful!

Comment 4

[Makoto Kato [:m_kato]]

Attachment: test case

test case

Comment 5

[Makoto Kato [:m_kato]]

Ah, why do we use style transaction for editing UI?

Comment 6

[Makoto Kato [:m_kato]]

Attachment: Bug 1663638 - Don't use edit transaction for editing UI. r=masayuki

Although we use CSS property for Inline table editing UI, we use edit
transaction for it unfortunately. When hiding this UI, since removing
element doesn't use edit transaction, transaction will be canceled before
showing this UI.

It is unnecessary to use edit transaction for UI, so we shouldn't use it.

Comment 7

[matteo.sindona]

Hello Makoto, thank you for your answer !

Is there any chance this can be fixed in a future Mozilla release ? Thank you!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2b9a766c616
Don't use edit transaction for editing UI. r=masayuki

Comment 9

[Makoto Kato [:m_kato]]

(In reply to matteo.sindona from comment #7)

Hello Makoto, thank you for your answer !

Is there any chance this can be fixed in a future Mozilla release ? Thank you!

This will be fixed by Firefox 82. 81 is too late to fix this.

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c2b9a766c616