1663677 - fxaccounts doesn't build with rust beta/nightly

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Because of https://github.com/rust-lang/rust/issues/76480.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1663677 - Fix macro hygiene usage in fxaccounts/rust-bridge. r=eoger,lina,rfkelly

This prevents us from building with rust beta/nightly.

This is technically a Rust regression, see
https://github.com/rust-lang/rust/issues/76480, though I think that this
should've never worked.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d73f925b6cf
Fix macro hygiene usage in fxaccounts/rust-bridge. r=lina

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on bridge.rs

Backout link: https://hg.mozilla.org/integration/autoland/rev/a63fdc72e12f0a30262eac350eed84f988b08153
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315104860&repo=autoland&lineNumber=44335

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bfeb9c69bfa
Fix macro hygiene usage in fxaccounts/rust-bridge. r=eoger,lina

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/0bfeb9c69bfa

Comment 6

[Josh Stone]

Would this change make sense for esr78 too?

In RHEL we are not holding the rust toolchain back, so our Firefox ESR build will eventually need to work with 1.47+ too.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9174409 [details]
Bug 1663677 - Fix macro hygiene usage in fxaccounts/rust-bridge. r=eoger,lina,rfkelly

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Build fix with newer rust toolchains.
• User impact if declined: None
• Fix Landed on Version: 82
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Rejiggers a bit some macro code that no longer compiles because of a rust fix.
• String or UUID changes made by this patch: none

Comment 8

[Emilio Cobos Álvarez (:emilio)]

(In reply to Josh Stone from comment #6)
Seems fair :)

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9174409 [details]
Bug 1663677 - Fix macro hygiene usage in fxaccounts/rust-bridge. r=eoger,lina,rfkelly

approved for 78.4

Comment 10

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/cb29365df8b4

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9174409 [details]
Bug 1663677 - Fix macro hygiene usage in fxaccounts/rust-bridge. r=eoger,lina,rfkelly

Beta/Release Uplift Approval Request

• User impact if declined: None, build fix for Rust 1.47
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just refactored the code a bit to keep it building after a rust breaking change.
• String changes made/needed: none

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 9174409 [details]
Bug 1663677 - Fix macro hygiene usage in fxaccounts/rust-bridge. r=eoger,lina,rfkelly

we're not going to touch 81 for this