1663694 - [traceback] ValueError: A string literal cannot contain NUL (0x00) characters: /signature/bugzilla

Status: RESOLVED FIXED

(Socorro :: Webapp, defect, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Sentry report: https://sentry.prod.mozaws.net/operations/socorro-new-prod/issues/9403544/

ValueError: A string literal cannot contain NUL (0x00) characters.
  File "django/core/handlers/exception.py", line 34, in inner
    response = get_response(request)
  File "django/core/handlers/base.py", line 115, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "django/core/handlers/base.py", line 113, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "crashstats/signature/views.py", line 64, in inner
    return view(request, *args, **kwargs)
  File "crashstats/signature/views.py", line 558, in signature_bugzilla
    models.BugAssociation.objects.get_bugs_and_related_bugs(signatures=[signature])
  File "crashstats/crashstats/models.py", line 42, in get_bugs_and_related_bugs
    bug_ids = [
  File "django/db/models/query.py", line 274, in __iter__
    self._fetch_all()
  File "django/db/models/query.py", line 1242, in _fetch_all
    self._result_cache = list(self._iterable_class(self))
  File "django/db/models/query.py", line 144, in __iter__
    return compiler.results_iter(tuple_expected=True, chunked_fetch=self.chunked_fetch, chunk_size=self.chunk_size)
  File "django/db/models/sql/compiler.py", line 1092, in results_iter
    results = self.execute_sql(MULTI, chunked_fetch=chunked_fetch, chunk_size=chunk_size)
  File "django/db/models/sql/compiler.py", line 1140, in execute_sql
    cursor.execute(sql, params)
  File "django/db/backends/utils.py", line 67, in execute
    return self._execute_with_wrappers(sql, params, many=False, executor=self._execute)
  File "django/db/backends/utils.py", line 76, in _execute_with_wrappers
    return executor(sql, params, many, context)
  File "django/db/backends/utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

We hit a bunch of these a week or two ago. I'm not sure why (fuzzing? funky signature report?), but it's worth looking into and probably an easy fix.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5567: bug 1663694: prevent nulls in signature arg in signature_bugzilla view

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5567: "bug 1663694: prevent nulls in signature arg in signature_bugzilla view" in 29948d7.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

I pushed the latest changes to prod in bug #1664250. Marking as FIXED.