1663708 - [perfdocs] Find tests to add to documentation using manifests instead of path searching

Status: RESOLVED FIXED

(Testing :: Performance, task, P2)

Description

[Greg Mierzwinski [:sparky]]

Bug 1662706 will add manifests to organize/gather performance tests. We'll be able to make use of this is perfdocs to gather the tests to document. This change will need to be made since some tests (like xpchsell) are not in perftest folders or files.

Comment 2

[Myeongjun Go]

Hello sparky :)
I have question before working this issue.
This structure find files using path searching based on perfdocs directory [0]
Is this intend to make manifest and searching file?

So then, Should I make ini(i.e, manifest file) file and write path[1] to find file(e.g, config.yml, index.rst)?

[0]
https://searchfox.org/mozilla-central/rev/89d33e1c3b0a57a9377b4815c2f4b58d933b7c32/tools/lint/perfdocs/gatherer.py#73

[1] e.g
python/mozperftest/perfdocs
testing/raptor/raptor/perfdocs

Comment 3

[Greg Mierzwinski [:sparky]]

Hi Jun :)

So this issue would involve changing this code to use the following: https://searchfox.org/mozilla-central/source/tools/lint/perfdocs/framework_gatherers.py#221-223

from moztest.resolve import TestResolver

tests = resolver.resolve_tests(paths=None, flavor="perftest")

Rather than searching through the entire source tree for the tests, we can make use of the moztest resolver to find them. We shouldn't be modifying how the perfdocs directories are found. This change is only for the mozperftest tests, the raptor tests discovery doesn't need to change.

Does that answer your question/concerns?

Comment 4

[Myeongjun Go]

Oh, I misunderstood about this. I thought that I had to make manifest file to find test file.
But, each pefrtest file already have been registered at perftest.ini and I just use function you guide to find test file.
Am I understand right? :)

Comment 5

[Greg Mierzwinski [:sparky]]

You got it! :)

Comment 6

[Myeongjun Go]

Attachment: Bug 1663708 - [perfdocs] Find tests to add to documentation using manifests instead of path searching r=sparky

Comment 7

[Greg Mierzwinski [:sparky]]

:sylvestre, is there anything in our linters/reviewbot that make or use of an m-c build already? For perfdocs+mozperftest, we need to find existing tests using moztest but we can't find all of them without a build.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90ab0a1b16cb
[perfdocs] Find tests to add to documentation using manifests instead of path searching r=sparky,perftest-reviewers

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/90ab0a1b16cb