Closed Bug 1663715 Opened 4 years ago Closed 4 years ago

style_traits and style doesn't build with rust nightly.

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect

Tracking

(firefox-esr78 fixed, firefox82 fixed)

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- fixed
firefox82 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

Bug 1663715 - Update syn and proc-macro2 so that Firefox can build on Rust nightly again. r=froydnj,#build
47 bytes, text/x-phabricator-request
jcristau
: approval-mozilla-release-
RyanVM
: approval-mozilla-esr78+
Details | Review
No description provided.

Generated with:

cargo update -p syn --precise 1.0.40
./mach vendor rust

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e2cede25c027
Update syn and proc-macro2 so that Firefox can build on Rust nightly again. r=froydnj

https://hg.mozilla.org/mozilla-central/rev/e2cede25c027

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

Comment on attachment 9174428 [details]
Bug 1663715 - Update syn and proc-macro2 so that Firefox can build on Rust nightly again. r=froydnj,#build

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Build fix with newer rust versions.
  • User impact if declined: none
  • Fix Landed on Version: 82
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): build-only dependency update.
  • String or UUID changes made by this patch: none
Attachment #9174428 - Flags: approval-mozilla-esr78?

I tried to apply this patch to 78.3.1 but build will fail with

[...]
3:40.97 error: proc-macro derive panicked
3:40.97 --> servo/components/style/values/specified/text.rs:471:48
3:40.97 |
3:40.97 471 | #[derive(MallocSizeOf, SpecifiedValueInfo, ToComputedValue, ToResolvedValue, ToShmem)]
3:40.97 | ^^^^^^^^^^^^^^^
3:40.97 |
3:40.97 = help: message: type Group(TypeGroup { group_token: Group, elem: Path(TypePath { qself: None, path: Path { leading_colon: None, segments: [PathSegment { ident: Ident { ident: "u8", span: #18155 bytes(9325329..9325331) }, arguments: None }] } }) }) cannot be mapped yet
3:40.97 thread '<unnamed>' panicked at 'type Group(TypeGroup { group_token: Group, elem: Path(TypePath { qself: None, path: Path { leading_colon: None, segments: [PathSegment { ident: Ident { ident: "u8", span: #18597 bytes(9325329..9325331) }, arguments: None }] } }) }) cannot be mapped yet', /var/tmp/portage/www-client/firefox-78.3.1/work/firefox-78.3.1/servo/components/derive_common/cg.rs:211:19
3:40.97 stack backtrace:
3:40.97 0: 0x7f41c7b44120 - std::backtrace_rs::backtrace::libunwind::trace::h577ea05e9ca4629a
3:40.97 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/../../backtrace/src/backtrace/libunwind.rs:96
3:40.97 1: 0x7f41c7b44120 - std::backtrace_rs::backtrace::trace_unsynchronized::h50b9b72b84c7dd56
3:40.97 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/../../backtrace/src/backtrace/mod.rs:66
3:40.97 2: 0x7f41c7b44120 - std::sys_common::backtrace::_print_fmt::h6541cf9823837fac
3:40.97 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/sys_common/backtrace.rs:79
3:40.97 3: 0x7f41c7b44120 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::hf64fbff071026df5
3:40.97 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/sys_common/backtrace.rs:58
3:40.97 4: 0x7f41c7bb21bc - core::fmt::write::h9ddafa4860d8adff
3:40.97 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/core/src/fmt/mod.rs:1082
3:40.97 5: 0x7f41c7b36447 - std::io::Write::write_fmt::h1d2ee292d2b65481
3:40.97 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/io/mod.rs:1514
3:40.97 6: 0x7f41c7b48de0 - std::sys_common::backtrace::_print::ha25f9ff5080d886d
3:40.97 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/sys_common/backtrace.rs:61
3:40.97 7: 0x7f41c7b48de0 - std::sys_common::backtrace::print::h213e8aa8dc5405c0
3:40.97 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/sys_common/backtrace.rs:48
3:40.97 8: 0x7f41c7b48de0 - std::panicking::default_hook::{{closure}}::h6482fae49ef9d963
3:40.97 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/panicking.rs:200
3:40.97 9: 0x7f41c7b48b2c - std::panicking::default_hook::he30ad7589e0970f9
3:40.97 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/panicking.rs:219
3:40.97 10: 0x7f41c7b49588 - std::panicking::rust_panic_with_hook::haa1ed36ada4ffb03
3:40.97 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/panicking.rs:573
3:40.97 11: 0x7f41c7b49139 - std::panicking::begin_panic_handler::{{closure}}::h7001af1bb21aeaeb
3:40.97 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/panicking.rs:476
3:40.97 12: 0x7f41c7b445ac - std::sys_common::backtrace::__rust_end_short_backtrace::h39910f557f5f2367
3:40.97 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/sys_common/backtrace.rs:153
3:40.97 13: 0x7f41c7b490f9 - rust_begin_unwind
3:40.97 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/panicking.rs:475
3:40.97 14: 0x7f41c7b490ab - std::panicking::begin_panic_fmt::hc1b1320af38b7e12
3:40.97 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/panicking.rs:429
3:40.97 15: 0x7f41c7757f14 - derive_common::cg::map_type_params::h479de368ea70496f
3:40.97 16: 0x7f41c77466da - style_derive::to_computed_value::derive_to_value::{{closure}}::h71558c08e4548735
3:40.97 17: 0x7f41c773efdd - style_derive::to_computed_value::derive_to_value::h099dba45e3acbbe7
3:40.97 18: 0x7f41c773bdb8 - style_derive::to_resolved_value::derive::h0b221375b73b0a7c
3:40.97 19: 0x7f41c77724b3 - style_derive::derive_to_resolved_value::hf4cff238ff01d63e
3:40.97 20: 0x7f41c776e200 - core::ops::function::FnOnce::call_once::h203ff315d64aeba9
3:40.97 21: 0x7f41c7739aa1 - proc_macro::bridge::client::Client<fn(proc_macro::TokenStream) .> proc_macro::TokenStream>::expand1::run::{{closure}}::h60f29866afeb22d9
3:40.97 22: 0x7f41c77391ba - proc_macro::bridge::client::run_client::{{closure}}::{{closure}}::h903dd40cf548d7f8
3:40.97 23: 0x7f41c772933e - proc_macro::bridge::scoped_cell::ScopedCell<T>::set::{{closure}}::h1f71b7e9165026da
3:40.97 24: 0x7f41c7729862 - proc_macro::bridge::scoped_cell::ScopedCell<T>::replace::h916e3104573d2ec4
3:40.97 25: 0x7f41c772931e - proc_macro::bridge::scoped_cell::ScopedCell<T>::set::h890849d6cee9f64e
3:40.97 26: 0x7f41c7739977 - proc_macro::bridge::client::<impl proc_macro::bridge::Bridge>::enter::{{closure}}::hd1f2308c6e36cbf5
3:40.97 27: 0x7f41c77326f4 - std::thread::local::LocalKey<T>::try_with::haeb6b4894732cb11
3:40.97 28: 0x7f41c7732322 - std::thread::local::LocalKey<T>::with::h349325344ce128e8
3:40.97 29: 0x7f41c7731dcc - proc_macro::bridge::client::<impl proc_macro::bridge::Bridge>::enter::h9f2ecb5ef8fffeaf
3:40.97 30: 0x7f41c77390b2 - proc_macro::bridge::client::run_client::{{closure}}::h633dbe2433eccbfc
3:40.97 31: 0x7f41c7738dc0 - <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::h935a23c397181749
3:40.97 32: 0x7f41c776d56a - std::panicking::try::do_call::h97a1787a93d6bd8e
3:40.97 33: 0x7f41c777265d - __rust_try
3:40.97 34: 0x7f41c776d4b8 - std::panicking::try::h663390a9a3181dee
3:40.97 35: 0x7f41c7739ca2 - std::panic::catch_unwind::h8f86cadbb6dcaec4
3:40.97 36: 0x7f41c7738ef3 - proc_macro::bridge::client::run_client::haa272c92485c9f99
3:40.97 37: 0x7f41c7739a59 - proc_macro::bridge::client::Client<fn(proc_macro::TokenStream) .> proc_macro::TokenStream>::expand1::run::hbfdfb7bd90cae49a
3:40.97 38: 0x7f41db8f3a93 - <unknown>
3:40.97 39: 0x7f41db86855d - <rustc_expand::proc_macro::ProcMacroDerive as rustc_expand::base::MultiItemModifier>::expand::ha5ce5795bb9e30b1
3:40.98 40: 0x7f41db931ed3 - rustc_expand::expand::MacroExpander::fully_expand_fragment::h80d7f33d8c730416
3:40.98 41: 0x7f41db930a50 - rustc_expand::expand::MacroExpander::expand_crate::h05086322299b6712
3:40.98 42: 0x7f41d7b8ae9f - <unknown>
3:40.98 43: 0x7f41d7bd6684 - <unknown>
3:40.98 44: 0x7f41d7bb36c9 - <unknown>
3:40.98 45: 0x7f41d7b8decf - <unknown>
3:40.98 46: 0x7f41d7bd5965 - <unknown>
3:40.98 47: 0x7f41d7bf6f73 - rustc_interface::queries::Queries::expansion::h56d30ab93a299881
3:40.98 48: 0x7f41d78a0887 - <unknown>
3:40.98 49: 0x7f41d7834f27 - <unknown>
3:40.98 50: 0x7f41d78a2513 - <unknown>
3:40.98 51: 0x7f41d78809fa - <unknown>
3:40.98 52: 0x7f41d7895957 - <unknown>
3:40.98 53: 0x7f41d781edae - <unknown>
3:40.98 54: 0x7f41d6c2cf5a - <unknown>
3:40.98 55: 0x7f41d6b46fbe - start_thread
3:40.98 at /var/tmp/portage/sys-libs/glibc-2.32-r2/work/glibc-2.32/nptl/pthread_create.c:463
3:40.98 56: 0x7f41d6a7635f - clone
3:40.98 57: 0x0 - <unknown>
3:40.98 error: proc-macro derive panicked
3:40.98 --> servo/components/style/values/specified/text.rs:1090:65
3:40.98 |
3:40.98 1090 | #[derive(MallocSizeOf, SpecifiedValueInfo, ToComputedValue, ToResolvedValue, ToShmem)]
3:40.98 | ^^^^^^^^^^^^^^^
3:40.98 |
3:40.98 = help: message: type Group(TypeGroup { group_token: Group, elem: Path(TypePath { qself: None, path: Path { leading_colon: None, segments: [PathSegment { ident: Ident { ident: "u8", span: #18597 bytes(9325329..9325331) }, arguments: None }] } }) }) cannot be mapped yet
3:40.98 thread '<unnamed>' panicked at 'type Group(TypeGroup { group_token: Group, elem: Path(TypePath { qself: None, path: Path { leading_colon: None, segments: [PathSegment { ident: Ident { ident: "u8", span: #18597 bytes(9325329..9325331) }, arguments: None }] } }) }) cannot be mapped yet', /var/tmp/portage/www-client/firefox-78.3.1/work/firefox-78.3.1/servo/components/derive_common/cg.rs:211:19
3:40.98 stack backtrace:
3:40.98 0: 0x7f41c7b44120 - std::backtrace_rs::backtrace::libunwind::trace::h577ea05e9ca4629a
3:40.98 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/../../backtrace/src/backtrace/libunwind.rs:96
3:40.98 1: 0x7f41c7b44120 - std::backtrace_rs::backtrace::trace_unsynchronized::h50b9b72b84c7dd56
3:40.98 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/../../backtrace/src/backtrace/mod.rs:66
3:40.98 2: 0x7f41c7b44120 - std::sys_common::backtrace::_print_fmt::h6541cf9823837fac
3:40.98 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/sys_common/backtrace.rs:79
3:40.98 3: 0x7f41c7b44120 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::hf64fbff071026df5
3:40.98 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/sys_common/backtrace.rs:58
3:40.98 4: 0x7f41c7bb21bc - core::fmt::write::h9ddafa4860d8adff
3:40.98 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/core/src/fmt/mod.rs:1082
3:40.98 5: 0x7f41c7b36447 - std::io::Write::write_fmt::h1d2ee292d2b65481
3:40.98 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/io/mod.rs:1514
3:40.98 6: 0x7f41c7b48de0 - std::sys_common::backtrace::_print::ha25f9ff5080d886d
3:40.98 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/sys_common/backtrace.rs:61
3:40.98 7: 0x7f41c7b48de0 - std::sys_common::backtrace::print::h213e8aa8dc5405c0
3:40.98 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/sys_common/backtrace.rs:48
3:40.98 8: 0x7f41c7b48de0 - std::panicking::default_hook::{{closure}}::h6482fae49ef9d963
3:40.98 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/panicking.rs:200
3:40.98 9: 0x7f41c7b48b2c - std::panicking::default_hook::he30ad7589e0970f9
3:40.98 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/panicking.rs:219
3:40.98 10: 0x7f41c7b49588 - std::panicking::rust_panic_with_hook::haa1ed36ada4ffb03
3:40.98 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/panicking.rs:573
3:40.98 11: 0x7f41c7b49139 - std::panicking::begin_panic_handler::{{closure}}::h7001af1bb21aeaeb
3:40.98 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/panicking.rs:476
3:40.98 12: 0x7f41c7b445ac - std::sys_common::backtrace::__rust_end_short_backtrace::h39910f557f5f2367
3:40.98 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/sys_common/backtrace.rs:153
3:40.98 13: 0x7f41c7b490f9 - rust_begin_unwind
3:40.98 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/panicking.rs:475
3:40.98 14: 0x7f41c7b490ab - std::panicking::begin_panic_fmt::hc1b1320af38b7e12
3:40.98 at /rustc/18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/panicking.rs:429
3:40.98 15: 0x7f41c7758904 - derive_common::cg::map_type_params::h8e53b3a0583b176a
3:40.98 16: 0x7f41c774640a - style_derive::to_computed_value::derive_to_value::{{closure}}::h4c945cddd06ad3f1
3:40.98 17: 0x7f41c77415dd - style_derive::to_computed_value::derive_to_value::h0e17b092390f9b8e
3:40.98 18: 0x7f41c7747098 - style_derive::to_computed_value::derive::h037b4e9b1e114f8c
3:40.98 19: 0x7f41c7772403 - style_derive::derive_to_computed_value::h5f8fd743a96cac9c
3:40.98 20: 0x7f41c776e200 - core::ops::function::FnOnce::call_once::h203ff315d64aeba9
3:40.98 21: 0x7f41c7739aa1 - proc_macro::bridge::client::Client<fn(proc_macro::TokenStream) .> proc_macro::TokenStream>::expand1::run::{{closure}}::h60f29866afeb22d9
3:40.98 22: 0x7f41c77391ba - proc_macro::bridge::client::run_client::{{closure}}::{{closure}}::h903dd40cf548d7f8
3:40.98 23: 0x7f41c772933e - proc_macro::bridge::scoped_cell::ScopedCell<T>::set::{{closure}}::h1f71b7e9165026da
3:40.98 24: 0x7f41c7729862 - proc_macro::bridge::scoped_cell::ScopedCell<T>::replace::h916e3104573d2ec4
3:40.98 25: 0x7f41c772931e - proc_macro::bridge::scoped_cell::ScopedCell<T>::set::h890849d6cee9f64e
3:40.98 26: 0x7f41c7739977 - proc_macro::bridge::client::<impl proc_macro::bridge::Bridge>::enter::{{closure}}::hd1f2308c6e36cbf5
3:40.98 27: 0x7f41c77326f4 - std::thread::local::LocalKey<T>::try_with::haeb6b4894732cb11
3:40.98 28: 0x7f41c7732322 - std::thread::local::LocalKey<T>::with::h349325344ce128e8
3:40.98 29: 0x7f41c7731dcc - proc_macro::bridge::client::<impl proc_macro::bridge::Bridge>::enter::h9f2ecb5ef8fffeaf
3:40.98 30: 0x7f41c77390b2 - proc_macro::bridge::client::run_client::{{closure}}::h633dbe2433eccbfc
3:40.98 31: 0x7f41c7738dc0 - <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::h935a23c397181749
3:40.98 32: 0x7f41c776d56a - std::panicking::try::do_call::h97a1787a93d6bd8e
3:40.98 33: 0x7f41c777265d - __rust_try
3:40.98 34: 0x7f41c776d4b8 - std::panicking::try::h663390a9a3181dee
3:40.98 35: 0x7f41c7739ca2 - std::panic::catch_unwind::h8f86cadbb6dcaec4
3:40.99 36: 0x7f41c7738ef3 - proc_macro::bridge::client::run_client::haa272c92485c9f99
3:40.99 37: 0x7f41c7739a59 - proc_macro::bridge::client::Client<fn(proc_macro::TokenStream) .> proc_macro::TokenStream>::expand1::run::hbfdfb7bd90cae49a
3:40.99 38: 0x7f41db8f3a93 - <unknown>
3:40.99 39: 0x7f41db86855d - <rustc_expand::proc_macro::ProcMacroDerive as rustc_expand::base::MultiItemModifier>::expand::ha5ce5795bb9e30b1
3:40.99 40: 0x7f41db931ed3 - rustc_expand::expand::MacroExpander::fully_expand_fragment::h80d7f33d8c730416
3:40.99 41: 0x7f41db930a50 - rustc_expand::expand::MacroExpander::expand_crate::h05086322299b6712
3:40.99 42: 0x7f41d7b8ae9f - <unknown>
3:40.99 43: 0x7f41d7bd6684 - <unknown>
3:40.99 44: 0x7f41d7bb36c9 - <unknown>
3:40.99 45: 0x7f41d7b8decf - <unknown>
3:40.99 46: 0x7f41d7bd5965 - <unknown>
3:40.99 47: 0x7f41d7bf6f73 - rustc_interface::queries::Queries::expansion::h56d30ab93a299881
3:40.99 48: 0x7f41d78a0887 - <unknown>
3:40.99 49: 0x7f41d7834f27 - <unknown>
3:40.99 50: 0x7f41d78a2513 - <unknown>
3:40.99 51: 0x7f41d78809fa - <unknown>
3:40.99 52: 0x7f41d7895957 - <unknown>
3:40.99 53: 0x7f41d781edae - <unknown>
3:40.99 54: 0x7f41d6c2cf5a - <unknown>
3:40.99 55: 0x7f41d6b46fbe - start_thread
3:40.99 at /var/tmp/portage/sys-libs/glibc-2.32-r2/work/glibc-2.32/nptl/pthread_create.c:463
3:40.99 56: 0x7f41d6a7635f - clone
3:40.99 57: 0x0 - <unknown>
3:40.99 error: proc-macro derive panicked
3:40.99 --> servo/components/style/values/specified/text.rs:1090:48
3:40.99 |
3:40.99 1090 | #[derive(MallocSizeOf, SpecifiedValueInfo, ToComputedValue, ToResolvedValue, ToShmem)]
3:40.99 | ^^^^^^^^^^^^^^^
3:40.99 |
3:40.99 = help: message: type Group(TypeGroup { group_token: Group, elem: Path(TypePath { qself: None, path: Path { leading_colon: None, segments: [PathSegment { ident: Ident { ident: "u8", span: #18597 bytes(9325329..9325331) }, arguments: None }] } }) }) cannot be mapped yet
3:40.99 warning: ignoring -C extra-filename flag due to -o flag
3:40.99 error: aborting due to 21 previous errors; 1 warning emitted
3:40.99 error: could not compile style.
3:40.99 Caused by:
3:40.99 process didn't exit successfully: CARGO=/opt/rust-bin-1.47.0/bin/cargo-bin-1.47.0 CARGO_CRATE_NAME=style CARGO_MANIFEST_DIR=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox-78.3.1/servo/components/style CARGO_PKG_AUTHORS='The Servo Project Developers' CARGO_PKG_DESCRIPTION='' CARGO_PKG_HOMEPAGE='' CARGO_PKG_LICENSE=MPL-2.0 CARGO_PKG_LICENSE_FILE='' CARGO_PKG_NAME=style CARGO_PKG_REPOSITORY='' CARGO_PKG_VERSION=0.0.1 CARGO_PKG_VERSION_MAJOR=0 CARGO_PKG_VERSION_MINOR=0 CARGO_PKG_VERSION_PATCH=1 CARGO_PKG_VERSION_PRE='' LD_LIBRARY_PATH='/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/release/deps:/opt/rust-bin-1.47.0/lib' OUT_DIR=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/build/style-bb11e6b0161a60f0/out /usr/bin/sccache /usr/bin/rustc --crate-name style servo/components/style/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=2 -C panic=abort -C embed-bitcode=no --cfg 'feature="bindgen"' --cfg 'feature="gecko"' --cfg 'feature="gecko_profiler"' --cfg 'feature="nsstring"' --cfg 'feature="regex"' --cfg 'feature="serde"' --cfg 'feature="toml"' -C metadata=e4c7b931f04d3cbe -C extra-filename=-e4c7b931f04d3cbe --out-dir /var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -C linker=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox-78.3.1/build/cargo-linker -L dependency=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps -L dependency=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/release/deps --extern app_units=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libapp_units-75b9847cccbd6399.rmeta --extern arrayvec=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libarrayvec-c35ddafc9d245b22.rmeta --extern atomic_refcell=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libatomic_refcell-aa9484e392169f0a.rmeta --extern bitflags=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libbitflags-dfe5110262fdfb75.rmeta --extern byteorder=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libbyteorder-20bf648f78290fc4.rmeta --extern cssparser=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libcssparser-addc7819476056c4.rmeta --extern derive_more=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/release/deps/libderive_more-cebb22b72de1e04a.so --extern euclid=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libeuclid-5701af1f8f0dd6a3.rmeta --extern fallible=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libfallible-4274f930c716e4eb.rmeta --extern fxhash=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libfxhash-b76dc20d9d355d25.rmeta --extern hashbrown=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libhashbrown-ea894caf9ea3ab54.rmeta --extern hashglobe=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libhashglobe-3be7496e79791f17.rmeta --extern indexmap=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libindexmap-46cbc93759fe248b.rmeta --extern itertools=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libitertools-2d0fdf353af127f4.rmeta --extern itoa=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libitoa-ca79b5560b51d18c.rmeta --extern lazy_static=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/liblazy_static-4f32eec0b3c4c54f.rmeta --extern log=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/liblog-69cb376d3137165f.rmeta --extern malloc_size_of=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libmalloc_size_of-99d46628777e7a80.rmeta --extern malloc_size_of_derive=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/release/deps/libmalloc_size_of_derive-bf0e57e0e9ee533a.so --extern matches=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libmatches-c7575918e2868f8d.rmeta --extern debug_unreachable=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libdebug_unreachable-42ad7cbee4469fdc.rmeta --extern nsstring=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libnsstring-410514c64274df89.rmeta --extern num_derive=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/release/deps/libnum_derive-450e2c5ee792cd08.so --extern num_integer=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libnum_integer-6df0ab7dd84a9ad9.rmeta --extern num_traits=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libnum_traits-0499fe81175b2184.rmeta --extern num_cpus=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libnum_cpus-b321f9adafd20a2c.rmeta --extern owning_ref=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libowning_ref-40bdd2005e25bd4c.rmeta --extern parking_lot=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libparking_lot-4539521a26b991ce.rmeta --extern precomputed_hash=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libprecomputed_hash-6a83b25870adc3f9.rmeta --extern rayon=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/librayon-68a0884f803161ee.rmeta --extern selectors=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libselectors-b7350f39093c42ef.rmeta --extern serde=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libserde-a0021946be6a98d3.rmeta --extern servo_arc=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libservo_arc-cb1b6ca92e652c46.rmeta --extern smallbitvec=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libsmallbitvec-9819bebd6069b11f.rmeta --extern smallvec=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libsmallvec-a132837d2880d839.rmeta --extern static_prefs=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libstatic_prefs-18b85232c354d54a.rmeta --extern style_derive=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/release/deps/libstyle_derive-dc0897ab72079516.so --extern style_traits=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libstyle_traits-288bcc8ae0b70d67.rmeta --extern thin_slice=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libthin_slice-82ed40f4bc9ccd79.rmeta --extern time=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libtime-9054f33124636add.rmeta --extern to_shmem=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libto_shmem-2ae921f8b728aba4.rmeta --extern to_shmem_derive=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/release/deps/libto_shmem_derive-559c4062a23c2326.so --extern uluru=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libuluru-4d3c639de067e95e.rmeta --extern unicode_bidi=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libunicode_bidi-650249037a57fdaa.rmeta --extern unicode_segmentation=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libunicode_segmentation-765a46c4a99946a4.rmeta --extern void=/var/tmp/portage/www-client/firefox-78.3.1/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libvoid-9ae8f94a2792f6dc.rmeta -C opt-level=2 --cap-lints warn -C codegen-units=1 (exit code: 1)
3:40.99 warning: build failed, waiting for other jobs to finish...

Thanks for doing the digging! I'll request uplift of those too.

Comment on attachment 9174428 [details]
Bug 1663715 - Update syn and proc-macro2 so that Firefox can build on Rust nightly again. r=froydnj,#build

Beta/Release Uplift Approval Request

  • User impact if declined: None, build fix for newer rust versions requested in bug 1670579.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): build-only change
  • String changes made/needed: none
Attachment #9174428 - Flags: approval-mozilla-release?

Comment on attachment 9174428 [details]
Bug 1663715 - Update syn and proc-macro2 so that Firefox can build on Rust nightly again. r=froydnj,#build

we're not going to touch 81 for this.

Attachment #9174428 - Flags: approval-mozilla-release? → approval-mozilla-release-

can it at least be considered for 78.4.1 or 78.5 esr ? a patch touching 98 files isnt nice to handle for downstreams.

Flags: needinfo?(jcristau)

It's on the list to be considered for 78.5 already, see comment 5.

Flags: needinfo?(jcristau)

Comment on attachment 9174428 [details]
Bug 1663715 - Update syn and proc-macro2 so that Firefox can build on Rust nightly again. r=froydnj,#build

Approved for 78.5esr.

Attachment #9174428 - Flags: approval-mozilla-esr78? → approval-mozilla-esr78+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: