1663733 - Add telemetry for the time from print initiation to FrameLoader.printPreview() call and return

Status: RESOLVED FIXED

(Toolkit :: Printing, task, P1)

Description

[Jonathan Watt [:jwatt]]

We currently have telemetry to measure how long the background tasks to fetch printer information take. That's not a direct measure of how long we take before we ask the platform code to start creating the print though, and if we fix bug 1663712 then the existing telemetry is no longer useful for that purpose. We should have direct stats for this as a more direct measure of the experience users are getting.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1663733. Add telemetry for the time from print initiation to FrameLoader.printPreview() call and completion. r=bobowen,sfoster,emalysz

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: Data review

Comment 3

[Chris H-C :chutten]

Comment on attachment 9176001 [details]
Data review

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 89.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

Yes. Jonathan Watt is responsible for renewing or removing the collection before it expires in Firefox 89.

---

Result: datareview+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e787c1b0a30
Add telemetry for the time from print initiation to FrameLoader.printPreview() call and completion. r=emalysz

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out changeset for eslint failure on content/print.js.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=0e787c1b0a30c1f20d4ac814dcd9fefb83253aaa&selectedTaskRun=E9C6QWLOT_OcJXZUuscLBQ.0

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=315867923&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/d8c79d60dadf9fbc11558a6715c7f12616400ef9

Comment 6

[Jonathan Watt [:jwatt]]

Meh. Lando screwed up the automerge ( https://hg.mozilla.org/integration/autoland/rev/0e787c1b0a30c1f20d4ac814dcd9fefb83253aaa#l1.39 ).

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f31315be0d54
Add telemetry for the time from print initiation to FrameLoader.printPreview() call and completion. r=emalysz

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f31315be0d54