1663790 - Crash in [@ mozilla::fontlist::FontList::Alloc]

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This is a regression from bug 1533462 (same crash signatures can also be observed when it landed in late June).

Crash report: https://crash-stats.mozilla.org/report/index/36494a4c-b8b2-474f-84ea-6fd170200908

Top 10 frames of crashing thread:

0 libxul.so mozilla::fontlist::FontList::Alloc gfx/thebes/SharedFontList.cpp:690
1 libxul.so mozilla::fontlist::FontList::SetLocalNames gfx/thebes/SharedFontList.cpp:817
2 libxul.so gfxPlatformFontList::InitFontList gfx/thebes/gfxPlatformFontList.cpp:504
3 libxul.so gfxPlatformGtk::CreatePlatformFontList gfx/thebes/gfxPlatformGtk.cpp:241
4 libxul.so gfxPlatform::Init gfx/thebes/gfxPlatform.cpp:991
5 libxul.so gfxPlatform::GetPlatform gfx/thebes/gfxPlatform.cpp:509
6 libxul.so mozilla::widget::GfxInfoBase::GetContentBackend widget/GfxInfoBase.cpp:1760
7 libxul.so NS_InvokeByIndex 
8 libxul.so XPCWrappedNative::CallMethod js/xpconnect/src/XPCWrappedNative.cpp:1141
9 libxul.so XPC_WN_GetterSetter js/xpconnect/src/XPCWrappedNativeJSOps.cpp:986

Comment 1

[Jonathan Kew [:jfkthame]]

Ah, I see how this would happen - if there's a very large number of fonts installed, the array we're trying to allocate here could exceed the SHM_BLOCK_SIZE limit. I have a patch in progress that will fix this.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1663790 - Support oversized shared-memory blocks in the font list when needed for large allocations. r=jwatt

Comment 3

[Julien Cristau [:jcristau]]

Jonathan can you take a look at the patch?

Comment 4

[Jonathan Watt [:jwatt]]

Yup - done.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14b425483d95
Support oversized shared-memory blocks in the font list when needed for large allocations. r=jwatt

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/14b425483d95