Only call saveSettingsToPrefs in the frontend code when the user actually prints
Categories
(Toolkit :: Printing, defect, P3)
Tracking
()
People
(Reporter: jwatt, Unassigned)
References
Details
(Whiteboard: [print2020] [old-ui-] )
Now that bug 1653340 has landed, we shoud stop calling saveSettingsToPrefs in the frontend code. This arguably should have happened in bug 1653319. Prior to the fix for that bug it was necessary to save the settings in order to communicate them to the platform code. Now the platform code doesn't even read the saved settings when the pref for the new UI is enabled, so saving the prefs just messes up the saved settings unnecessarily.
|
Reporter | |
Comment 1•5 years ago
|
||
Perhaps the code that uses settingFlags can also be simplified.
|
|
Reporter | |
Comment 2•5 years ago
|
||
Hmm, I've noticed that Chrome does seem to save at least some settings that are chosen in its preview UI without requiring a Print/Save. So presumably their UI people thought that was desirable.
I'd also note bug 1627055.
|
||
Comment 3•5 years ago
|
||
:shorlander, can you confirm if the expectation is that any changes the user makes in the print UI should be persisted even when the user cancels -so they are restored next time the user opens the print UI?
|
||
Comment 4•5 years ago
|
||
Moving to 83.
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Comment 5•4 years ago
|
||
(Moving bugs to 86, part 1.)
|
|
||
Comment 6•4 years ago
|
||
Moving things to 88, cause we're mostly on Proton these days…
|
|
Reporter | |
Comment 7•4 years ago
|
||
Actually I've changed my mind on this. Forget I filed it. ;-)
Description
•