1663884 - <input type="number"> should use TYPE_NUMBER_FLAG_DECIMAL too

Status: RESOLVED FIXED

(GeckoView :: IME, defect, P3)

Description

[Makoto Kato [:m_kato]]

From https://github.com/mozilla-mobile/fenix/issues/14757

When using <input type="number">, we set InputType.TYPE_CLASS_NUMBER and InputType.TYPE_NUMBER_VARIATION_NORMAL (https://searchfox.org/mozilla-central/rev/b2716c233e9b4398fc5923cbe150e7f83c7c6c5b/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoEditable.java#1632-1635).

But Blink uses InputType.TYPE_CLASS_NUMBER and InputType.TYPE_NUMBER_FLAG_DECIMAL (https://source.chromium.org/chromium/chromium/src/+/master:content/public/android/java/src/org/chromium/content/browser/input/ImeUtils.java;l=99;drc=cfa2ae6b10d00be94ee6fba822245bbf3d842acf).

So this may be compatibility issue since LG keyboard don't set decimal point without InputType.TYPE_NUMBER_FLAG_DECIMAL.

Comment 1

[poojanrathod]

I am new to open source and i want to contribute. So, i would like to solve this bug.

Comment 2

[Makoto Kato [:m_kato]]

(In reply to poojanrathod from comment #1)

I am new to open source and i want to contribute. So, i would like to solve this bug.

Yes, thank you. You can take this bug and I can help this issue until you fix this. If you have any question, ping me.

Comment 3

[poojanrathod]

Hi,

As you rightly suggested InputType.TYPE_NUMBER_FLAG_DECIMAL needs to needed in GeeckoEditable.java . But i was unable to find the right repository having the following code. Could you please point me in that direction?

Comment 4

[Makoto Kato [:m_kato]]

(In reply to poojanrathod from comment #3)

Hi,

As you rightly suggested InputType.TYPE_NUMBER_FLAG_DECIMAL needs to needed in GeeckoEditable.java . But i was unable to find the right repository having the following code. Could you please point me in that direction?

GeckoView (Gecko) code base is managed by "mercurial" VCS and url is https://hg.mozilla.org/mozilla-central. But you can use "git" (see the following guide).

Contribution guide is for https://firefox-source-docs.mozilla.org/mobile/android/geckoview/contributor/geckoview-quick-start.html (if using git). When using this guide, we can build GeckoView and simple web browser (as known as GeckoView example). You can test your fix via GeckoView example web browser. This issue isn't related to Fenix (new Firefox).

Also, https://searchfox.org is source code index for our Mozilla products. mozilla-central index is for https://hg.mozilla.org/mozilla-central, and indices of some mobile products are https://searchfox.org/mozilla-mobile/source/ into git repositories in https://github.com/mozilla-mobile/.

Comment 5

[Makoto Kato [:m_kato]]

After writing fix, you need code review to land the fix to mozilla-central. See https://firefox-source-docs.mozilla.org/mobile/android/geckoview/contributor/contributing-to-mc.html. We use Phabricator as review tool, so we have to submit fix to Phabricator. Mozilla has submission tool as moz-phab.

Comment 6

[desaimudra50]

if anyone is not working on this I would like to work on it

Comment 7

[h20190017]

Attachment: Bug 1663884 - <input type=number> should use TYPE_NUMBER_FLAG_DECIMAL too. r?m_kato

Comment 8

[h20190017]

Attachment: ⚙ D95773 Bug 1663884 - _input type=number_ should use TYPE_NUMBER_FLAG_DECIMAL too. r_m_kato.html

Comment 9

[h20190017]

Submitted the patch. Please review. Thanks.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7b20ab818cd
<input type=number> should use TYPE_NUMBER_FLAG_DECIMAL too. r=m_kato,geckoview-reviewers,snorp

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a7b20ab818cd

Comment 12

[Chris Peterson [:cpeterson]]

Moving some input bugs to the new GeckoView::IME component.