Closed Bug 1663884 Opened 5 months ago Closed 3 months ago

<input type="number"> should use TYPE_NUMBER_FLAG_DECIMAL too

Categories

(GeckoView :: General, defect, P3)

Unspecified
All

Tracking

(firefox84 fixed)

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: m_kato, Assigned: h20190017, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=java])

Attachments

(2 files)

From https://github.com/mozilla-mobile/fenix/issues/14757

When using <input type="number">, we set InputType.TYPE_CLASS_NUMBER and InputType.TYPE_NUMBER_VARIATION_NORMAL (https://searchfox.org/mozilla-central/rev/b2716c233e9b4398fc5923cbe150e7f83c7c6c5b/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoEditable.java#1632-1635).

But Blink uses InputType.TYPE_CLASS_NUMBER and InputType.TYPE_NUMBER_FLAG_DECIMAL (https://source.chromium.org/chromium/chromium/src/+/master:content/public/android/java/src/org/chromium/content/browser/input/ImeUtils.java;l=99;drc=cfa2ae6b10d00be94ee6fba822245bbf3d842acf).

So this may be compatibility issue since LG keyboard don't set decimal point without InputType.TYPE_NUMBER_FLAG_DECIMAL.

Assignee: m_kato → nobody
Mentor: m_kato
Keywords: good-first-bug
Whiteboard: [lang=java]
Priority: -- → P3

I am new to open source and i want to contribute. So, i would like to solve this bug.

(In reply to poojanrathod from comment #1)

I am new to open source and i want to contribute. So, i would like to solve this bug.

Yes, thank you. You can take this bug and I can help this issue until you fix this. If you have any question, ping me.

Hi,

As you rightly suggested InputType.TYPE_NUMBER_FLAG_DECIMAL needs to needed in GeeckoEditable.java . But i was unable to find the right repository having the following code. Could you please point me in that direction?

(In reply to poojanrathod from comment #3)

Hi,

As you rightly suggested InputType.TYPE_NUMBER_FLAG_DECIMAL needs to needed in GeeckoEditable.java . But i was unable to find the right repository having the following code. Could you please point me in that direction?

GeckoView (Gecko) code base is managed by "mercurial" VCS and url is https://hg.mozilla.org/mozilla-central. But you can use "git" (see the following guide).

Contribution guide is for https://firefox-source-docs.mozilla.org/mobile/android/geckoview/contributor/geckoview-quick-start.html (if using git). When using this guide, we can build GeckoView and simple web browser (as known as GeckoView example). You can test your fix via GeckoView example web browser. This issue isn't related to Fenix (new Firefox).

Also, https://searchfox.org is source code index for our Mozilla products. mozilla-central index is for https://hg.mozilla.org/mozilla-central, and indices of some mobile products are https://searchfox.org/mozilla-mobile/source/ into git repositories in https://github.com/mozilla-mobile/.

After writing fix, you need code review to land the fix to mozilla-central. See https://firefox-source-docs.mozilla.org/mobile/android/geckoview/contributor/contributing-to-mc.html. We use Phabricator as review tool, so we have to submit fix to Phabricator. Mozilla has submission tool as moz-phab.

if anyone is not working on this I would like to work on it

Assignee: nobody → h20190017
Status: NEW → ASSIGNED

Submitted the patch. Please review. Thanks.

Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a7b20ab818cd
<input type=number> should use TYPE_NUMBER_FLAG_DECIMAL too. r=m_kato,geckoview-reviewers,snorp
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.