1663898 - Has Cranelift really shipped on aarch64?

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

This is a bit embarrassing.

A current version of Fenix shows a build id which ought to contain Geckoview with the recent Cranelift changes, but about:config shows cranelift is disabled there.

Not sure, but it might be that the pref's default isn't enabled because the _ARM64_ define doesn't exist when substituting in modules/libpref/all/init.js.

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Build peers: what should i use to test for a device running an aarch64 build, in modules/libpref/init/all.js? (Is _ARM64_ not substituted in this file?)

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Nathan helped on matrix, thanks.

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1663898: Really enable Cranelift by default on aarch64 builds; r?froydnj

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Confirmed the above patch is sufficient to enable Cranelift by default (at least according to the compiled Geckoview example from a try build with this patch).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/648847a283fe
Really enable Cranelift by default on aarch64 builds; r=froydnj

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/648847a283fe