1663938 - Assert that the collector doesn't trigger barriers during marking

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P3)

Description

[Jon Coppeard (:jonco)]

Ideally the collector would never do anything that could trigger barriers. Currently we can assert this for marking, so let's do that.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1663938 - Assert that the collector doesn't trigger barriers during marking r?sfink

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f6ea0586a34
Assert that the collector doesn't trigger barriers during marking r=sfink

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0f6ea0586a34

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out for causing Bug 1664326.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=ObJjtREgR1KJ1QqpmdUtQA.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Crunnable&searchStr=android%2C7.0%2Cx86-64%2Cdebug%2Ctest-android-em-7.0-x86_64%2Fdebug-geckoview-cppunit-1proc%2Ccppunit&tochange=f3a40f0de7b98ed50d5c30050bf206fc5c72b136&fromchange=50a87c4ddf15bd22d4332e7fab170f3fc1a5bd94

Failure log: https://bugzilla.mozilla.org/show_bug.cgi?id=1664326#c0

Backout link: https://hg.mozilla.org/integration/autoland/rev/c2c9ac84ff3bf9ed22418223fbde7257b3e003e3

Job is green on the backout. https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Cpending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=e503fe6d5db6dd89f196f73b382e430feb80004b&searchStr=cpp&selectedTaskRun=NCg9DUevQEmrKbJif7AIVA.0

Comment 5

[Cosmin Sabou [:CosminS]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/c2c9ac84ff3bf9ed22418223fbde7257b3e003e3

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9dd67fd23c9e
Assert that the collector doesn't trigger barriers during marking r=sfink

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/9dd67fd23c9e