Closed Bug 1663976 Opened 4 years ago Closed 4 years ago

Disabled "Show search suggestions in address bar results" still shows suggestions with a one-off selected

Categories

(Firefox :: Address Bar, defect)

Desktop
All
defect

Tracking

()

RESOLVED INVALID
Tracking Status
firefox80 --- unaffected
firefox81 --- unaffected
firefox82 --- affected

People

(Reporter: muirpablo, Unassigned)

References

(Blocks 1 open bug)

Details

tested on
Firefox nightly 82.0a1 and affects:
Windows10 64bit
MacOS 10.15
Ubuntu 18.04

"Show search suggestions in address bar results" disabled still shows suggestions with a one-off selected

steps to reproduce

  1. go to about:preferences#search
  2. uncheck "Show search suggestions in address bar results"
  3. open new tab, search "cats" > suggestions are not visible.
  4. click on the duckduckgo one-off for example and keep clicking other one-offs.

actual result
suggestions appears after i click a one-off

expected result
if user removed the checkbox suggestions should not appear.

Notes: Before the one-offs changes we did not have this problem with suggestions.

I think this is expected, it should work the same as when you use a restriction character, the preferences control what happens in a normal search (just typing the search terms in the urlbar), Search mode is an opt-in into search. With the question mark restriction character for example, we still provide suggestions even if they are disabled, because the user explicitly asked to search.
If instead you completely disable suggestions (by unchecking the top level "Show Search Suggestions" pref, then nothing should appear in any case.
UX is looking into changes to make to clarify the preferences UI that at this point is a bit disconnected from the expectations.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.